Bug 1092196 - Fix trace snprintf size argument found by compilation
Summary: Fix trace snprintf size argument found by compilation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: trace
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-29 00:37 UTC by Pranith Kumar K
Modified: 2014-11-11 08:31 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.6.0beta1
Clone Of:
Environment:
Last Closed: 2014-11-11 08:31:20 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2014-04-29 00:37:32 UTC
Description of problem:
Compilation of trace xlator fails with the following

trace.c: In function 'trace_stat_to_str':
trace.c:43:31: warning: argument to 'sizeof' in 'snprintf' call is the same expression as the destination; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess]
         snprintf (str, sizeof (str),
                               ^


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-04-29 00:43:57 UTC
REVIEW: http://review.gluster.org/7586 (debug/trace: Fix length issue found in compilation) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-04-29 07:35:53 UTC
COMMIT: http://review.gluster.org/7586 committed in master by Vijay Bellur (vbellur) 
------
commit 4963ec017ef93b22e6c0b929b5fe0633f7010f45
Author: Pranith Kumar K <pkarampu>
Date:   Tue Apr 29 06:05:46 2014 +0530

    debug/trace: Fix length issue found in compilation
    
    Change-Id: I1cd7fd6464d0912294009c2293ed70f3f6744930
    BUG: 1092196
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/7586
    Reviewed-by: Anand Avati <avati>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Niels de Vos 2014-09-22 12:39:15 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-11-11 08:31:20 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.