Red Hat Bugzilla – Bug 1092342
nsslapd-ndn-cache-max-size accepts any invalid value.
Last modified: 2015-03-05 04:34:30 EST
Description of problem: nsslapd-ndn-cache-max-size accepts any invalid value. Version-Release number of selected component (if applicable): 389-ds-base-1.3.1.6-25.el7.x86_64 How reproducible: Always Steps to Reproduce: 1. ldapmodify -h localhost -p 389 -D "cn=directory manager" -w ***** <<EOF dn: cn=config changetype: modify replace: nsslapd-ndn-cache-max-size nsslapd-ndn-cache-max-size: ~ EOF 2. systemctl restart dirsrv@dhcp201-149 Actual results: DS does not give any error and operation is successful. Expected results: Error is expected.
Upstream ticket: https://fedorahosted.org/389/ticket/47790
https://fedorahosted.org/389/ticket/47790#comment:1 The input string "value" is converted to long integer by atol, which does not check the error, but returns 0 when the input is invalid. The set function then adjusts the size to the default size, and it returns SUCCESS. I think this is the right behaviour. Probably, we could log it in the error log, but I don't think we need to return an error there. int config_set_ndn_cache_max_size(const char *attrname, char *value, char *errorbuf, int apply ) { [...] size = atol(value); if(size < 0){ size = 0; /* same as -1 */ }
Fixed upstream
Ldapmodify rejects the invalid value. Hence, marking the bug as verified. [root@mgmt7 export]# ldapmodify -x -p 8739 -D "cn=Directory Manager" -w Secret123 -h localhost << EOF > dn: cn=config > changetype: modify > replace: nsslapd-ndn-cache-max-size > nsslapd-ndn-cache-max-size: ~ > EOF modifying entry "cn=config" ldap_modify: Operations error (1) additional info: (nsslapd-ndn-cache-max-size) value (~) is invalid
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-0416.html