Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1092361

Summary: Params --succeedd is not autocompleted in 'action step'.
Product: Red Hat Enterprise Virtualization Manager Reporter: Ondra Machacek <omachace>
Component: ovirt-engine-cliAssignee: Juan Hernández <juan.hernandez>
Status: CLOSED DUPLICATE QA Contact: Shai Revivo <srevivo>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.4.0CC: acathrow, gklein, iheim, oramraz, pstehlik, Rhev-m-bugs, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-04-29 09:12:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ondra Machacek 2014-04-29 07:24:22 UTC
Description of problem:
Params --succeeded is not autocompleted in 'action step'.

Version-Release number of selected component (if applicable):
rhevm-cli-3.4.0.6-3.el6ev.noarch

How reproducible:
always

Steps to Reproduce:
action step '98d24b8c-4de1-4429-9b5d-0a38cac98ceb' end --job-identifier '0b8cc7f7-2b6a-4b5c-a15f-9a9dc0eca025'   --grace_period-expiry 10 --async false <TAB><TAB>

Actual results:
async                correlation_id       force                grace_period-expiry  status-state         

Expected results:
async                correlation_id       force                grace_period-expiry  status-state      *succeeded*


Additional info:

Comment 1 Juan Hernández 2014-04-29 09:12:09 UTC
This happens because the "succeeded" parameter isn't documented in the RESTAPI metadata. It needs to be fixed in the metadata, something like this:

diff --git a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml b/backend/manager/modules/resta
index 7e5fc87..6ae37d2 100644
--- a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
+++ b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
@@ -4615,7 +4615,8 @@ actions:
       parameterType: Action
       signatures:
       - mandatoryArguments: {}
-        optionalArguments: {action.force: 'xs:boolean', action.status.state: 'xs:string', action.async: 'xs:boolean', action.grace_per
+        optionalArguments: {action.force: 'xs:boolean', action.status.state: 'xs:string', action.async: 'xs:boolean', action.grace_per
+          succeeded: 'xs:boolean'}
         description: invoke the command to end the specified step of an external job with an optional agrument to force the operation
     urlparams: {}
     headers:

But I'm not sure if this parameter should be optional or mandatory. We already have bug 1087916 for that, which is more severe. As the fix for that bug will fix this as well, I'm closing this as duplicate.

*** This bug has been marked as a duplicate of bug 1087916 ***