Bug 1092632 - PATCH: Update OpenBSD data
Summary: PATCH: Update OpenBSD data
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libosinfo
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zeeshan Ali
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-29 15:34 UTC by Cole Robinson
Modified: 2016-09-20 01:42 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-05-12 15:15:43 UTC
Embargoed:


Attachments (Terms of Use)
Update OpenBSD patch (2.34 KB, text/plain)
2014-04-29 15:34 UTC, Cole Robinson
no flags Details
Update OpenBSD information and add test data (7.66 KB, patch)
2014-05-02 08:23 UTC, Jasper Lievisse Adriaanse
no flags Details | Diff

Description Cole Robinson 2014-04-29 15:34:35 UTC
Created attachment 890851 [details]
Update OpenBSD patch

This was originally filed on the libosinfo trac bug tracker by jasperla on 2014-04-03:

> This patch adds the two most recent OpenBSD releases to the database.

teuf followed up:

> If you have the ISOs for these OpenBSD versions available, could you also add test cases for them in test/isodata/openbsd/ ? You can get the info in the correct format using isoinfo -d -i $bsd_iso (and you generally only need the first few megabytes of the image if you have to download them again to get this data).

Comment 1 Cole Robinson 2014-04-29 15:35:06 UTC
Jasper, please see teuf's request in the above comment

Comment 2 Jasper Lievisse Adriaanse 2014-05-02 08:23:06 UTC
Created attachment 891746 [details]
Update OpenBSD information and add test data

Hi,

Here's the updated patch which includes the isoinfo data now.
Should I update it to on the libosinfo trac?

Comment 3 Cole Robinson 2014-05-02 13:37:55 UTC
Thanks Jasper. Don't worry about trac, the bug tracker there will be discontinued shortly.

Patch looks good to me. Christophe, can you review/commit ?

Comment 4 Christophe Fergeau 2014-05-12 14:57:17 UTC
Looks good to me, is it worth adding <release-date> tags?

diff --git a/data/oses/openbsd.xml.in b/data/oses/openbsd.xml.in
index cad2e6e..062eb47 100644
--- a/data/oses/openbsd.xml.in
+++ b/data/oses/openbsd.xml.in
@@ -217,6 +217,7 @@
     <upgrades id='http://openbsd.org/openbsd/5.3'/>
     <derives-from id='http://openbsd.org/openbsd/5.3'/>
 
+    <release-date>2013-11-01</release-date>
 
     <media arch='i686'>
       <iso>
@@ -247,6 +248,7 @@
     <upgrades id='http://openbsd.org/openbsd/5.4'/>
     <derives-from id='http://openbsd.org/openbsd/5.4'/>
 
+    <release-date>2014-05-01</release-date>
 
     <media arch='i686'>
       <iso>

Comment 5 Jasper Lievisse Adriaanse 2014-05-12 15:05:58 UTC
Sounds good to me.

Comment 6 Christophe Fergeau 2014-05-12 15:15:43 UTC
Pushed, thanks for the patch! https://git.fedorahosted.org/cgit/libosinfo.git/commit/?id=749420b6429c66ae97facee92882560ba0b33038

Comment 7 Christophe Fergeau 2014-05-12 15:43:45 UTC
Hmm no clue what the proper resolution is here...


Note You need to log in before you can comment on or make changes to this bug.