Bug 1092977 - Cannot use Ctrl+c to quit console installation on Windows
Summary: Cannot use Ctrl+c to quit console installation on Windows
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Installer
Version: 6.3.0
Hardware: Unspecified
OS: Windows
unspecified
medium
Target Milestone: ER3
: EAP 6.3.0
Assignee: Thomas Hauser
QA Contact: Petr Kremensky
URL:
Whiteboard:
Depends On: 1013973
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-30 11:01 UTC by Petr Kremensky
Modified: 2017-10-10 00:23 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1013973
Environment:
Last Closed: 2014-06-28 15:39:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Petr Kremensky 2014-04-30 11:01:58 UTC
+++ This bug was initially created as a clone of Bug #1013973 +++

Description of problem:
 I am unable to quit from console installation using Ctrl+C shortcut.

OS:
 Windows

Version-Release number of selected component (if applicable):
 EAP 6.2.0.ER3

Steps to Reproduce:
 1. Start the console installation
 2. Press Ctrl+C

Actual results:
 Nothing really happens.

Expected results:
 Installation will quit.

Additional info:
 Regression against EAP 6.1.1

--- Additional comment from Miles Tjandrawidjaja on 2013-10-21 15:02:05 EDT ---

Hello,

I've looked into this, and found out a change in the jline dependency is needed to resolve this issue. After some testing I found out jline read the Insert button and Ctrl-C as the same character code on windows. Making a change in jline's ConsoleReader.java class will allow use to exit with Ctrl-C (but also if the Insert button if pressed)

If you would like to exit with a similar combination I have made some changes so that Ctrl-D will exit your program. The reason for this is because there is a bug where Ctrl-D will pass in a null value into our installer. Also the unix meaning of Ctrl-D means the end of any further text input.

http://git.app.eng.bos.redhat.com/izpack.git/commit/?h=izpack-wip&id=892cdca7e01a9b558a81dad60fb1c2863c116670

While playing with jline I also got the tilde to expand the the full path of the user's home directory, both in windows and unix (https://bugzilla.redhat.com/show_bug.cgi?id=883419). Although on windows paths starting with C:\ seems like it still won't auto-complete(https://bugzilla.redhat.com/show_bug.cgi?id=1013972). If we end up being able to modify jline I may look into these more.

Let me know what actions to take if any. Thanks.

--- Additional comment from Petr Kremensky on 2013-10-22 02:47:27 EDT ---

Hi Miles,
can you than look more into jline and try to modify it so we get the same behaviour for Ctlr+C and Insert as we have with 6.1.1 installer? 
Thanks

--- Additional comment from Miles Tjandrawidjaja on 2013-10-23 10:43:07 EDT ---

Hello,

Jline has been updated so Ctrl+C will not exit the console installation on Windows. Modifications have also been made for places where jline is not used to enable Ctrl+C to exit from console installation on windows.

http://git.app.eng.bos.redhat.com/izpack.git/commit/?h=izpack-wip

--- Additional comment from Miles Tjandrawidjaja on 2013-10-23 11:02:59 EDT ---

Correction to above comment.
Ctrl+C will 'now' exit the console installation on Windows.

--- Additional comment from Petr Kremensky on 2013-11-01 10:25:13 EDT ---

Verified on EAP 6.2.0.ER7 installer.

--- Additional comment from Lucas Costi on 2013-11-13 00:36:40 EST ---

Release note written, please let us know if anything needs to be added or corrected.

--- Additional comment from Petr Kremensky on 2013-11-13 02:54:30 EST ---

We may add the note about jline reading the Insert button and Ctrl-C as the same character code on windows -> exit the console installation. Someone may be confused by this.

--- Additional comment from Lucas Costi on 2013-11-13 23:39:02 EST ---

Thanks Petr; release note updated.

--- Additional comment from mark yarborough on 2013-12-15 11:16:32 EST ---

End of release cleanup for EAP 6.2.0.

Comment 1 Miles Tjandrawidjaja 2014-04-30 13:19:56 UTC
Dependency has been updated, console mode in windows should be able to exit with Ctrl+C just like before.

http://git.app.eng.bos.redhat.com/git/installer-commons.git/commit/?id=030b0c6f03f615d97064c733b632c93948c1bcc1

Comment 2 Thomas Hauser 2014-04-30 13:30:44 UTC
Just to be clear, EAP 6.3.0 ER2 was built with the incorrect version of jline. This version was older and didn't contain the fix for 1013973, which resulted in this regression.

Comment 3 Petr Kremensky 2014-05-07 12:13:45 UTC
Verified on EAP 6.3.0.ER3 installer.


Note You need to log in before you can comment on or make changes to this bug.