Description of problem: The "Reserve Workflow" (via the "Show Systems" button) allows selecting a system to reserve from the list of automated systems. However, it should also allow manual systems in this list. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: See description Additional info:
http://gerrit.beaker-project.org/#/c/3052/
Nick pointed out that we should bring this up on the beaker-devel list since it's a somewhat drastic change in behaviour -- people might not be expecting or wanting their Manual systems to be offered in the Reserve Workflow. However my reasoning for allowing it is that people can already reserve those Manual systems by finding them in Systems -> Available, going to the System page, clicking Take and then provisioning. We are just making it easier to do that through the scheduler instead (which is something I want to encourage). The system access policies will of course continue to be respected, so if you don't want your system to be reserved by people then you should not grant them Reserve permission.
We haven't heard from anyone that this is a bad idea so let's go ahead with it in 0.18.
In the context of the new system page design, it occurs to me that with this change, Manual system should perhaps show a split Take/Shedule Reservation quick action button by default.
Alternatively, we could make the quick action button *just* Schedule Reservation, and require users to go down into the detail tabs to manage manual provisioning.
(In reply to Amit Saha from comment #8) > In case it is not clear, loan a manual system to yourself and then you > should be able to reserve it via the workflow. The entire point of this patch is that you *don't* have to loan it to yourself first, any Manual system which you have 'reserve' permission on should be offered in Reserve Workflow when are picking a specific system.
(In reply to Dan Callaghan from comment #9) > (In reply to Amit Saha from comment #8) > > In case it is not clear, loan a manual system to yourself and then you > > should be able to reserve it via the workflow. > > The entire point of this patch is that you *don't* have to loan it to > yourself first, any Manual system which you have 'reserve' permission on > should be offered in Reserve Workflow when are picking a specific system. of course, my mistake. Anyway, it works - which is important. :)
Beaker 19.0 has been released.