Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg-daemon.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-epg-daemon-0.1.0-4.20140428giteb7f12a.fc20.src.rpm Description: epgd is part of the double team epgd+epg2vdr to effectively retrieve, store and import epg data to vdr. It is designed to handle large amount of data and pictures in a distributed environment with one epg-server and many possible vdr-clients - therefore it relays on mysql. Though it is possible to use epgd alone with mysql it only makes sense to use it as backend to the vdr-plugin epg2vdr. That being said you need to install, setup and configure mysql, epgd and epg2vdr in order to get a working environment. Fedora Account System Username: martinkg rpmlint vdr-epg-daemon-0.1.0-4.20140428giteb7f12a.fc20.x86_64.rpm vdr-epg-daemon.x86_64: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal vdr-epg-daemon.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-tool vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-showmerge vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-dropall vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-ls-channelids 1 packages and 0 specfiles checked; 0 errors, 7 warnings.
- Please, use macro and not hardlinks: sed -i \ -e 's|PREFIX = /usr/local|PREFIX = %{_prefix}|' \ -e 's|PLGDEST = $(DESTDIR)$(PREFIX)/lib/epgd/plugins|PLGDEST = $(DESTDIR)%{_libdir}/epgd|' \ Make.config - The 'vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87/tools/curlfuncs.cpp' file is released with a BSD(3clause) license and it's involved in the compilation. (http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario) Also, COPYING file reports a GPLv2 license. Fix the License tag. - %{_libdir}/epgd is not owned by the package - %{_libdir}/mysql/plugin is owned by 'mariadb-server'. It's a Requires package. - Optimization flags are not honored. (http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags) - Why 'Requires: vdr' is not explicit like your others VDR plugins ? - Please, leave a comment about upstream patch. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 59 files have unknown license. Detailed output of licensecheck in /home/sagitter/1093407-vdr-epg- daemon/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/epgd [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/epgd, /usr/lib64/mysql/plugin [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vdr-epg-daemon-0.1.0-4.20140428giteb7f12a.fc21.x86_64.rpm vdr-epg-daemon-0.1.0-4.20140428giteb7f12a.fc21.src.rpm vdr-epg-daemon.x86_64: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal vdr-epg-daemon.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.x86_64: E: non-standard-executable-perm /usr/lib64/mysql/plugin/mysqlepglv.so 0775L vdr-epg-daemon.x86_64: E: non-standard-executable-perm /usr/bin/epgd 0775L vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-tool vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-showmerge vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-dropall vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-ls-channelids vdr-epg-daemon.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal vdr-epg-daemon.src: W: spelling-error %description -l en_US epgd -> deep vdr-epg-daemon.src: W: spelling-error %description -l en_US mysql -> myself vdr-epg-daemon.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.src: W: file-size-mismatch epgd-tool.diff = 329, http://projects.vdr-developer.org/attachments/1691/epgd-tool.diff = 5427 2 packages and 0 specfiles checked; 2 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint vdr-epg-daemon vdr-epg-daemon.x86_64: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal vdr-epg-daemon.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.x86_64: E: non-standard-executable-perm /usr/lib64/mysql/plugin/mysqlepglv.so 0775L vdr-epg-daemon.x86_64: E: non-standard-executable-perm /usr/bin/epgd 0775L vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-tool vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-showmerge vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-dropall vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-ls-channelids 1 packages and 0 specfiles checked; 2 errors, 7 warnings. # echo 'rpmlint-done:' Requires -------- vdr-epg-daemon (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/perl config(vdr-epg-daemon) libarchive.so.13()(64bit) libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libexslt.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjansson.so.4()(64bit) libm.so.6()(64bit) libmysqlclient.so.18()(64bit) libmysqlclient.so.18(libmysqlclient_18)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxslt.so.1()(64bit) libxslt.so.1(LIBXML2_1.0.11)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) perl(Getopt::Long) perl(strict) rtld(GNU_HASH) vdr Provides -------- vdr-epg-daemon: config(vdr-epg-daemon) libepgd-epgdata.so()(64bit) vdr-epg-daemon vdr-epg-daemon(x86-64) Unversioned so-files -------------------- vdr-epg-daemon: /usr/lib64/epgd/libepgd-epgdata.so vdr-epg-daemon: /usr/lib64/mysql/plugin/mysqlepglv.so Source checksums ---------------- http://projects.vdr-developer.org/git/vdr-epg-daemon.git/snapshot/vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87.tar.bz2 : CHECKSUM(SHA256) this package : 6198c7ab03ebf02c66b9c1f6fed290810dbc5fe5fda7a282b5f670b8cac88645 CHECKSUM(SHA256) upstream package : 6198c7ab03ebf02c66b9c1f6fed290810dbc5fe5fda7a282b5f670b8cac88645 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -b 1093407 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Oh, I forgot, systemd BR are missing. (http://fedoraproject.org/wiki/Packaging:Systemd#Packaging)
(In reply to Antonio Trande from comment #1) > - Please, use macro and not hardlinks: > > sed -i \ > -e 's|PREFIX = /usr/local|PREFIX = %{_prefix}|' \ > -e 's|PLGDEST = $(DESTDIR)$(PREFIX)/lib/epgd/plugins|PLGDEST = > $(DESTDIR)%{_libdir}/epgd|' \ > Make.config done > - The > 'vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87/tools/curlfuncs. > cpp' file is > released with a BSD(3clause) license and it's involved in the compilation. done > (http://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Mixed_Source_Licensing_Scenario) > > Also, COPYING file reports a GPLv2 license. > Fix the License tag. fixed > - %{_libdir}/epgd is not owned by the package done > - %{_libdir}/mysql/plugin is owned by 'mariadb-server'. It's a Requires > package. added, done > - Why 'Requires: vdr' is not explicit like your others VDR plugins ? vdr-epg-daemon can act as a standalon daemon. I admit here a comment by ville ville.skytta about the dependency to vdr: Also, are you sure that this package really depends on vdr(abi)%{_isa} = %{vdr_apiversion}, or if a simple "Requires: vdr" would be enough? It doesn't seem to be a vdr plugin so I'd imagine it's not that strictly wired to VDR's API/ABI version. > - Please, leave a comment about upstream patch. > done > - Optimization flags are not honored. > (http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags) > if i add the optflags as below, %build # make %{?_smp_mflags} all make CFLAGS="%{optflags} -fPIC" CXXFLAGS="%{optflags} -fPIC" %{?_smp_mflags} all the compilation fails with the error message: + cd vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87 + make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC' 'CXXFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC' -j3 g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC -c -D_GNU_SOURCE -DTARGET='"epgd"' -DPLGDIR='"/usr/lib64/epgd"' -DUSEMD5 -DUSEUUID -DUSELIBXML -DUSELIBARCHIVE -I/usr/include/libxml2 -I/usr/include/libxml2 -o lib/db.o lib/db.c lib/db.c:9:20: fatal error: errmsg.h: No such file or directory #include <errmsg.h> ^ compilation terminated. have you any idea how to fix this ?
(In reply to MartinKG from comment #3) > > - Optimization flags are not honored. > > (http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags) > > > > if i add the optflags as below, > > %build > # make %{?_smp_mflags} all > make CFLAGS="%{optflags} -fPIC" CXXFLAGS="%{optflags} -fPIC" %{?_smp_mflags} > all > > the compilation fails with the error message: > > + cd vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87 > + make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches > -m64 -mtune=generic -fPIC' 'CXXFLAGS=-O2 -g -pipe -Wall > -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong > --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC' > -j3 > g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches > -m64 -mtune=generic -fPIC -c -D_GNU_SOURCE -DTARGET='"epgd"' > -DPLGDIR='"/usr/lib64/epgd"' -DUSEMD5 -DUSEUUID -DUSELIBXML -DUSELIBARCHIVE > -I/usr/include/libxml2 -I/usr/include/libxml2 -o lib/db.o lib/db.c > lib/db.c:9:20: fatal error: errmsg.h: No such file or directory > #include <errmsg.h> > ^ > compilation terminated. > > have you any idea how to fix this ? The '-I/usr/include/mysql' variabile is missing. 'errmsg.h' is an header file from 'mariadb-devel'. Try to patch 'Makefile.config' in main source directory in order to respect both compilation flags from upstream and from Fedora guidelines. Remember that are used both gcc and g++ (they need CFLAGS and CXXFLAGS respectively).
i added $(shell mysql_config --include) into the file Make.config DEFINES += -D_GNU_SOURCE -DTARGET='"$(TARGET)"' -DPLGDIR='"$(PLGDEST)"' \ -DUSEMD5 -DUSEUUID -DUSELIBXML -DUSELIBARCHIVE \ $(shell xml2-config --cflags) $(shell xslt-config --cflags) \ $(shell mysql_config --include) but then, the compilation fails with this error message: g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -c -D_GNU_SOURCE -DTARGET='""' -DPLGDIR='"/usr/lib64/epgd"' -DUSEMD5 -DUSEUUID -DUSELIBXML -DUSELIBARCHIVE -I/usr/include/libxml2 -I/usr/include/libxml2 -I/usr/include/mysql -o epgdata.o epgdata.c In file included from epgdata.c:11:0: epgdata.h:8:18: fatal error: epgd.h: No such file or directory #include "epgd.h" ^ compilation terminated.
(In reply to MartinKG from comment #5) > i added $(shell mysql_config --include) into the file Make.config > > DEFINES += -D_GNU_SOURCE -DTARGET='"$(TARGET)"' -DPLGDIR='"$(PLGDEST)"' \ > -DUSEMD5 -DUSEUUID -DUSELIBXML -DUSELIBARCHIVE \ > $(shell xml2-config --cflags) $(shell xslt-config --cflags) \ > $(shell mysql_config --include) > > but then, the compilation fails with this error message: > > g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches > -m64 -mtune=generic -c -D_GNU_SOURCE -DTARGET='""' > -DPLGDIR='"/usr/lib64/epgd"' -DUSEMD5 -DUSEUUID -DUSELIBXML -DUSELIBARCHIVE > -I/usr/include/libxml2 -I/usr/include/libxml2 -I/usr/include/mysql -o > epgdata.o epgdata.c > In file included from epgdata.c:11:0: > epgdata.h:8:18: fatal error: epgd.h: No such file or directory > #include "epgd.h" > ^ > compilation terminated. Probably this happens because you're imposing %{optflags} on 'make' command; don't do that but edit the 'CFLAGS' line defined in 'Make.config'.
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg-daemon.spec SRPM URL: https://www.dropbox.com/s/7nhvgk41kfiideh/vdr-epg-daemon-0.1.0-6.20140505gitd7fb6ca.fc20.src.rpm %changelog * Mon May 05 2014 Martin Gansser <martinkg> - 0.1.0-6.20140505gitd7fb6ca - rebuild for new git release - replaced hardlinks by macro in %%prep section - Fixed the License tag - added %%dir %%{_libdir}/epgd because it's owned by the package - added BR mariadb-server - added BR systemd-units - added comment about upstream patch - added fedora optflags to Make.config
(In reply to MartinKG from comment #7) > Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg-daemon.spec > This file has not been updated.
(In reply to Antonio Trande from comment #8) > (In reply to MartinKG from comment #7) > > Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg-daemon.spec > > > > This file has not been updated. Sorry for copy/paste the wrong link. Spec URL: https://www.dropbox.com/s/u05hbq6jhgsx41n/vdr-epg-daemon.spec SRPM URL: https://www.dropbox.com/s/7nhvgk41kfiideh/vdr-epg-daemon-0.1.0-6.20140505gitd7fb6ca.fc20.src.rpm %changelog * Mon May 05 2014 Martin Gansser <martinkg> - 0.1.0-6.20140505gitd7fb6ca - rebuild for new git release - replaced hardlinks by macro in %%prep section - Fixed the License tag - added %%dir %%{_libdir}/epgd because it's owned by the package - added BR mariadb-server - added BR systemd-units - added comment about upstream patch - added fedora optflags to Make.config
(In reply to MartinKG from comment #9) > - added fedora optflags to Make.config There are still some problems. This is a rawhide scratch build of your latest package: http://koji.fedoraproject.org/koji/taskinfo?taskID=6814402 Optimization flags are not respected and the arm builds fail. Your patch is CFLAGS += -fPIC -Wreturn-type -Wformat -pedantic -Wunused-variable -Wunused-label \ -Wunused-value -Wunused-function \ - -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 + -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 \ + $(OPTFLAGS) $(shell mysql_config --include) and these are optflags on a Fedora 64bit $ rpm --eval %{optflags} -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic 1. '-Wall' option enables all the warnings about constructions (see http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) including all W* already defined on upstream source. 2. There is a DEBUG mode definition with own cflags, always activated. 3. Also, ../epglv contains an own Makefile that must be edited separately. These three points condition the compilation. I changed your patch and the .spec file in order to impose our optimization flags. Then, epglv README is missing, I added it; I prefer to use 'cp -p' rather than 'mv' command. See the files attached.
Created attachment 892640 [details] vdr-epg-daemon.spec (proposed)
Created attachment 892641 [details] vdr-epg-daemon-makefile.patch (proposed)
@Antonio many thanks for your hard work, it's great. Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg-daemon.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-epg-daemon-0.1.0-7.20140505gitd7fb6ca.fc20.src.rpm %changelog * Mon May 05 2014 Martin Gansser <martinkg> - 0.1.0-7.20140505gitd7fb6ca - added macro for activate/deactivate debug option - optflags settings - added epglv README - used 'cp -p' rather than 'mv' for copying files from buildroot
> BuildRequires: mariadb-server mariadb-server is a Requires package. > 'summary-too-long' error from rpmlint $ rpmlint -I summary-too-long summary-too-long: The "Summary:" must not exceed 80 characters. > vdr-epg-daemon.i686: E: non-standard-executable-perm /usr/lib/mysql/plugin/mysqlepglv.so 0775L > vdr-epg-daemon.i686: E: non-standard-executable-perm /usr/bin/epgd 0775L These errors persist. Maybe better if we use install -pm 755 epgd %{buildroot}%{_bindir} install -pm 755 epglv/mysqlepglv.so %{buildroot}%{_libdir}/mysql/plugin
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg-daemon.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-epg-daemon-0.1.0-8.20140505gitd7fb6ca.fc20.src.rpm %changelog * Mon May 05 2014 Martin Gansser <martinkg> - 0.1.0-8.20140505gitd7fb6ca - removed unnecessary BR: mariadb-server - added mariadb-server to Requires - used %%install for installing and fix perm of files from buildroot
Package approved. - /usr/lib/mysql/plugin is owned by the 'mariadb-server' package. It's properly listed. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 59 files have unknown license. Detailed output of licensecheck in /home/sagitter/1093407-vdr-epg- daemon/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/mysql/plugin [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/mysql/plugin [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vdr-epg-daemon-0.1.0-8.20140505gitd7fb6ca.fc21.i686.rpm vdr-epg-daemon-0.1.0-8.20140505gitd7fb6ca.fc21.src.rpm vdr-epg-daemon.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd-tool vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd-showmerge vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd-dropall vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd-ls-channelids vdr-epg-daemon.src: W: spelling-error Summary(en_US) mysql -> myself vdr-epg-daemon.src: W: spelling-error %description -l en_US epgd -> deep vdr-epg-daemon.src: W: spelling-error %description -l en_US mysql -> myself vdr-epg-daemon.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end 2 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint vdr-epg-daemon vdr-epg-daemon.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd-tool vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd-showmerge vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd-dropall vdr-epg-daemon.i686: W: no-manual-page-for-binary epgd-ls-channelids 1 packages and 0 specfiles checked; 0 errors, 6 warnings. # echo 'rpmlint-done:' Requires -------- vdr-epg-daemon (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/perl config(vdr-epg-daemon) libarchive.so.13 libc.so.6 libcrypto.so.10 libcrypto.so.10(libcrypto.so.10) libcurl.so.4 libdl.so.2 libexslt.so.0 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libjansson.so.4 libm.so.6 libmysqlclient.so.18 libmysqlclient.so.18(libmysqlclient_18) libpthread.so.0 librt.so.1 libssl.so.10 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libuuid.so.1 libuuid.so.1(UUID_1.0) libxml2.so.2 libxml2.so.2(LIBXML2_2.4.30) libxml2.so.2(LIBXML2_2.6.0) libxslt.so.1 libxslt.so.1(LIBXML2_1.0.11) libz.so.1 libz.so.1(ZLIB_1.2.0) mariadb-server perl(Getopt::Long) perl(strict) rtld(GNU_HASH) systemd-units vdr Provides -------- vdr-epg-daemon: config(vdr-epg-daemon) libepgd-epgdata.so vdr-epg-daemon vdr-epg-daemon(x86-32) Unversioned so-files -------------------- vdr-epg-daemon: /usr/lib/epgd/libepgd-epgdata.so vdr-epg-daemon: /usr/lib/mysql/plugin/mysqlepglv.so Source checksums ---------------- http://projects.vdr-developer.org/git/vdr-epg-daemon.git/snapshot/vdr-epg-daemon-d7fb6caf0f84ad56c2ce2a0d9ef8b554d230ec75.tar.bz2 : CHECKSUM(SHA256) this package : ae3162e55b2bf680448ea767dac76530e3d697cc07408000f0c0bb71d70a1528 CHECKSUM(SHA256) upstream package : ae3162e55b2bf680448ea767dac76530e3d697cc07408000f0c0bb71d70a1528 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-i386 -b 1093407 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
@Antonio many thanks for the great review. New Package SCM Request ======================= Package Name: vdr-epg-daemon Short Description: A daemon to download EPG data from internet and manage it in a mysql database Owners: martinkg Branches: f20 f21 InitialCC:
Git done (by process-git-requests).
vdr-epg-daemon has been built successfully on fc20 and fc21.
vdr-epg-daemon-0.1.0-8.20140505gitd7fb6ca.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vdr-epg-daemon-0.1.0-8.20140505gitd7fb6ca.fc20
vdr-epg-daemon-0.2.0-1.20140507gitd5f1b4d.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vdr-epg-daemon-0.2.0-1.20140507gitd5f1b4d.fc20
guayadeque-0.3.7-2.svn1893.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/guayadeque-0.3.7-2.svn1893.fc20
vdr-epg-daemon-0.2.1-1.20140510gite1d19b8.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vdr-epg-daemon-0.2.1-1.20140510gite1d19b8.fc20
vdr-epg-daemon-0.2.1-2.20140512git997069a.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vdr-epg-daemon-0.2.1-2.20140512git997069a.fc20
guayadeque-0.3.7-2.svn1893.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.