Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://petersen.fedorapeople.org/reviews/ghc-srpm-macros.spec SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-srpm-macros-1.3-1.fc20.src.rpm Description: Macros used when generating source Haskell RPM packages.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6805218
macros.ghc-srpm were recently moved out of redhat-rpm-config into a ghc-rpm-macros subpackage called ghc-srpm-macros. But since the file should be stable and largely independent of ghc-rpm-macros which is updated frequently I think it is better that the srpm macros live in this separate package which redhat-rpm-config requires now. The package is itself (like perl-srpm-macros and ocaml-srpm-macros) is very simple and trivial so it should be a straightforward review.
rpmlint output: ghc-srpm-macros.noarch: W: no-url-tag ghc-srpm-macros.noarch: W: only-non-binary-in-usr-lib ghc-srpm-macros.noarch: W: no-documentation
I think we previously talked about the URL in irc. My take is that fedora pkg git will be a sufficient home for this tiny package so I don't see a strong need to add a URL beforehand or I could set it already to <http://pkgs.fedoraproject.org/cgit/ghc-srpm-macros.git>. I think it would be nice to ship this in F21 GA but it is not a blocker.
APPROVED, but yes please add a URL, especially since no LICENSE file is included here (but presumably exists in the upstream). Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-srpm-macros-1.3-1.fc20.noarch.rpm ghc-srpm-macros-1.3-1.fc20.src.rpm ghc-srpm-macros.noarch: W: no-url-tag ghc-srpm-macros.noarch: W: only-non-binary-in-usr-lib ghc-srpm-macros.noarch: W: no-documentation ghc-srpm-macros.src: W: no-url-tag 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ghc-srpm-macros ghc-srpm-macros.noarch: W: no-url-tag ghc-srpm-macros.noarch: W: only-non-binary-in-usr-lib ghc-srpm-macros.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- ghc-srpm-macros (rpmlib, GLIBC filtered): Provides -------- ghc-srpm-macros: ghc-srpm-macros Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b ghc-srpm-macros Buildroot used: fedora-20-x86_64 Active plugins: Generic, Haskell, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks for reviewing! (In reply to Ricky Elrod from comment #5) > APPROVED, but yes please add a URL, Okay I will, thanks. > especially since no LICENSE file is included here I should probably have commented more on this initially. I largely followed the packaging of the perl- and ocaml- -srpm-macros packages which also don't include a license files. Since it is just a file listing a few arches there is not too much to license anyway. :) http://koji.fedoraproject.org/koji/rpminfo?rpmID=5121489 http://koji.fedoraproject.org/koji/rpminfo?rpmID=5129300 > (but presumably exists in the upstream). Well pkg git for this package itself now becomes "upstream". :) It is true though that ghc-rpm-macros does have a license file (it is also a lot more complicated) though redhat-rpm-config (the former home of macros.ghc-srpm) doesn't. New Package SCM Request ======================= Package Name: ghc-srpm-macros Short Description: RPM macros for building Haskell source packages Upstream URL: Owners: petersen Branches: devel InitialCC: haskell-sig
added URL: New Package SCM Request ======================= Package Name: ghc-srpm-macros Short Description: RPM macros for building Haskell source packages Upstream URL: http://pkgs.fedoraproject.org/cgit/ghc-srpm-macros.git Owners: petersen Branches: devel InitialCC: haskell-sig
Git done (by process-git-requests).
Thanks again for reviewing this package in time for F21 feature freeze. We may backport this later to F20, I am not sure: currently in F20 macros.ghc-srpm is still part of redhat-rpm-config.