Bug 1093552 - [PATCH] install complete cityplacemarks.cache
Summary: [PATCH] install complete cityplacemarks.cache
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: marble
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-02 04:03 UTC by Yaakov Selkowitz
Modified: 2015-09-21 11:52 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-09-21 11:52:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch for rawhide (2.65 KB, patch)
2014-05-02 04:05 UTC, Yaakov Selkowitz
no flags Details | Diff
Patch for f20 (2.65 KB, patch)
2014-05-02 04:08 UTC, Yaakov Selkowitz
no flags Details | Diff

Description Yaakov Selkowitz 2014-05-02 04:03:22 UTC
There was an unintended effect in enabling MOBILE in marble-4.12.0-app_versions.patch: in data/CMakeLists.txt, a smaller "large-population" version of cityplacemarks.cache is installed instead of the larger, more complete version if MOBILE is enabled.  Not only that, but the file appears to be installed into the wrong location of $datadir/kde4/apps/marble/data/placemarks/placemarks/cityplacemarks.cache; the duplicate placemarks/ subdir is wrong.

I'm attaching patches for rawhide and F20 to fix marble-4.12.0-app_versions.patch to only disable marble-touch and leave marble-mobile to be built regardless of MOBILE.

Comment 1 Yaakov Selkowitz 2014-05-02 04:05:23 UTC
Created attachment 891679 [details]
Patch for rawhide

Comment 2 Yaakov Selkowitz 2014-05-02 04:08:08 UTC
Created attachment 891691 [details]
Patch for f20

Comment 3 Jaroslav Reznik 2015-03-03 15:45:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 4 Rex Dieter 2015-03-11 12:30:55 UTC
The supplied patch looks wrong to me, it seems to remove all of

add_subdirectory(marble-ui)
add_subdirectory(marble-qt)
add_subdirectory(marble-mobile)

taking a closer look.

Comment 5 Rex Dieter 2015-03-11 13:03:51 UTC
Decided to opt to modify app_versions patch to simply unconditionally install the larger cityplacemarks.cache file instead.

%changelog
* Wed Mar 11 2015 Rex Dieter <rdieter> - 1:14.12.3-3
- install complete cityplacemarks.cache (#1093552)
- disable -mobile (doesn't work very well)


Note You need to log in before you can comment on or make changes to this bug.