Spec URL: http://fedorapeople.org/~theinric/liblogging/liblogging.spec SRPM URL: http://fedorapeople.org/~theinric/liblogging/liblogging-1.0.4-1.fc20.src.rpm Description: liblogging is a collection of several components. The liblogging-stdlog component can be viewed as an enhanced version of the syslog(3) API. It retains the easy semantics, but makes the API more sophisticated "behind the scenes" with better support for multiple threads and flexibility for different log destinations (e.g. syslog and systemd journal). This package is a prerequisite for newer versions of rsyslog. Fedora Account System Username: theinric
It seems this first version contain only a single subpackage. And there is no main package. Perhaps the description should be changed appropriately? Or will another subpackages follow soon?
(In reply to Tomas Mraz from comment #1) > It seems this first version contain only a single subpackage. Technically 3. > And there is no main package. Perhaps the description should be changed appropriately? What part do you have in mind? The phrase "liblogging is a collection of several components" refers to the upstream package. > Or will another subpackages follow soon? Possibly.
(In reply to Tomas Heinrich from comment #2) > (In reply to Tomas Mraz from comment #1) > > It seems this first version contain only a single subpackage. > > Technically 3. OK, only a single non-devel non-debuginfo subpackage. > > And there is no main package. Perhaps the description should be changed appropriately? > > What part do you have in mind? > The phrase "liblogging is a collection of several components" refers to the > upstream package. Refers to it in which way? It seems confusing to me that the description refers to several components where in reality there is a single one in the reviewed package. I would definitely use different text for the main description and the -stdlog subpackage.
(In reply to Tomas Mraz from comment #3) > I would definitely use different text for the main description and the > -stdlog subpackage. I've altered the text a little. Is the package description the only issue you've encountered?
rpmlint -v /home/mraz/src/rpm/SRPMS/liblogging-1.0.4-1.fc19.src.rpm /home/mraz/src/rpm/RPMS/x86_64/liblogging-stdlog-1.0.4-1.fc19.x86_64.rpm /home/mraz/src/rpm/RPMS/x86_64/liblogging-stdlog-devel-1.0.4-1.fc19.x86_64.rpm /home/mraz/src/rpm/RPMS/x86_64/liblogging-debuginfo-1.0.4-1.fc19.x86_64.rpm liblogging.src: I: checking liblogging.src: W: spelling-error %description -l en_US stdlog -> std log, std-log, slogged rpmlint -v liblogging-1.0.4-1.fc19.src.rpm liblogging-stdlog-1.0.4-1.fc19.x86_64.rpm liblogging-stdlog-devel-1.0.4-1.fc19.x86_64.rpm liblogging-debuginfo-1.0.4-1.fc19.x86_64.rpm liblogging.src: W: spelling-error %description -l en_US journalemu -> journal emu, journal-emu, journalese liblogging.src: I: checking-url http://www.liblogging.org/ (timeout 10 seconds) liblogging.src: I: checking-url http://download.rsyslog.com/liblogging/liblogging-1.0.4.tar.gz (timeout 10 seconds) liblogging-stdlog.x86_64: I: checking liblogging-stdlog.x86_64: W: spelling-error %description -l en_US journalemu -> journal emu, journal-emu, journalese liblogging-stdlog.x86_64: W: spelling-error %description -l en_US syslog -> slog liblogging-stdlog.x86_64: W: spelling-error %description -l en_US systemd -> systems, system, system d liblogging-stdlog.x86_64: I: checking-url http://www.liblogging.org/ (timeout 10 seconds) liblogging-stdlog-devel.x86_64: I: checking liblogging-stdlog-devel.x86_64: I: checking-url http://www.liblogging.org/ (timeout 10 seconds) liblogging-debuginfo.x86_64: I: checking liblogging-debuginfo.x86_64: I: checking-url http://www.liblogging.org/ (timeout 10 seconds) 4 packages and 0 specfiles checked; 0 errors, 5 warnings. ACCEPT The package is compliant to Fedora guidelines. Minor nitpick - use parallel flags for make and also V=1 so the compile and link options are visible in the build log.
(In reply to Tomas Mraz from comment #5) > ACCEPT > The package is compliant to Fedora guidelines. Thanks for the review. > Minor nitpick - use parallel flags for make and also V=1 so the compile and > link options are visible in the build log. OK, I'll use this: make V=1 %{?_smp_mflags}
New Package SCM Request ======================= Package Name: liblogging Short Description: An easy to use logging library Owners: theinric Branches: f20 InitialCC:
Git done (by process-git-requests).