Spec URL: https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam-script.spec SRPM URL: https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam-script-1.1.7-1.fc20.src.rpm Description: pam_script is a module which allows to execute scripts after opening and/or closing a session using PAM. Fedora Account System Username: jtaylor History: https://bugzilla.redhat.com/show_bug.cgi?id=624705 This is my first package and need a sponsor. The goal is to have this package in Fedora and EPEL 5/6. Successful koji scratch builds can be found here: http://koji.fedoraproject.org/koji/taskinfo?taskID=6818625 (f20) http://koji.fedoraproject.org/koji/taskinfo?taskID=6818641 (el6) http://koji.fedoraproject.org/koji/taskinfo?taskID=6818658 (el5)
Looks good. One note: Your Source0 line needs either a comment or adjusting. See: http://fedoraproject.org/wiki/Packaging:SourceURL#Github
Thanks for the review Michael! I have updated the spec file and resultant srpm as indicated. https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam-script.spec https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam-script-1.1.7-1.fc20.src.rpm JT
Use your real name in Bugzilla, not only an email address. This package should be named pam_script instead of the current one you are using.
Thanks Christopher! I have made the adjustments as requested, the links now reflect the latest changes. https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam_script.spec https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam_script-1.1.7-1.fc20.src.rpm
scratch builds with the updated spec and src rpm are successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=6819858 (f20) http://koji.fedoraproject.org/koji/taskinfo?taskID=6819874 (el6) http://koji.fedoraproject.org/koji/taskinfo?taskID=6819892 (el5)
Follow this link step by step: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers Be careful when you read the lines. Thanks.
Thanks Christopher, I am reviewing again.
Discovered this package needs some more work. Will refine and resubmit.