Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
reset_touch_buttons() submits bad property values. It uses the XI 1.x device property calls which are modelled after the standard Xlib calls. For 32-bit values the data must be a long, not an int, otherwise Xlib reads garbage and sends that over to the server.
Version-Release number of selected component (if applicable):
gnome-settings-daemon-2.28.2-30.el6.x86_64
How reproducible:
sudo /usr/libexec/gsd-test-wacom on a 6.6 box with the rebased xorg-x11-drv-wacom fails. Alternatively, run it and then check the property values on the Wacom pad device with xinput list-props. The values are not the same that were submitted (second value is garbage).
Additional info:
There is an push/pop error handler around the calls to reset_touch_buttons. However, gdk3 documentation claims that gdk_error_trap_pop() didn't call gdk_flush() in gdk2, so we're not getting the error at the right time. gsd-test-wacom --sync triggers the error handler and thus doesn't crash.
Fix below:
diff --git a/plugins/wacom/gsd-wacom-manager.c b/plugins/wacom/gsd-wacom-manager.c
index 2c9b49f..915a095 100644
--- a/plugins/wacom/gsd-wacom-manager.c
+++ b/plugins/wacom/gsd-wacom-manager.c
@@ -532,7 +532,7 @@ reset_touch_buttons (XDevice *xdev,
for (i = 0; buttons[i].button != NULL; i++)
{
char *propname;
- int action[2]; /* press + release */
+ long action[2]; /* press + release */
Atom prop;
int mapped_button = buttons[i].num;
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://rhn.redhat.com/errata/RHBA-2016-0962.html
Description of problem: reset_touch_buttons() submits bad property values. It uses the XI 1.x device property calls which are modelled after the standard Xlib calls. For 32-bit values the data must be a long, not an int, otherwise Xlib reads garbage and sends that over to the server. Version-Release number of selected component (if applicable): gnome-settings-daemon-2.28.2-30.el6.x86_64 How reproducible: sudo /usr/libexec/gsd-test-wacom on a 6.6 box with the rebased xorg-x11-drv-wacom fails. Alternatively, run it and then check the property values on the Wacom pad device with xinput list-props. The values are not the same that were submitted (second value is garbage). Additional info: There is an push/pop error handler around the calls to reset_touch_buttons. However, gdk3 documentation claims that gdk_error_trap_pop() didn't call gdk_flush() in gdk2, so we're not getting the error at the right time. gsd-test-wacom --sync triggers the error handler and thus doesn't crash. Fix below: diff --git a/plugins/wacom/gsd-wacom-manager.c b/plugins/wacom/gsd-wacom-manager.c index 2c9b49f..915a095 100644 --- a/plugins/wacom/gsd-wacom-manager.c +++ b/plugins/wacom/gsd-wacom-manager.c @@ -532,7 +532,7 @@ reset_touch_buttons (XDevice *xdev, for (i = 0; buttons[i].button != NULL; i++) { char *propname; - int action[2]; /* press + release */ + long action[2]; /* press + release */ Atom prop; int mapped_button = buttons[i].num;