Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1095098 - 'Add/Remove Content-view' buttons under composite-view should be disabled when no CV is selected
Summary: 'Add/Remove Content-view' buttons under composite-view should be disabled wh...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.0.3
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: Unspecified
Assignee: Walden Raines
QA Contact: Katello QA List
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks: 1092222
TreeView+ depends on / blocked
 
Reported: 2014-05-07 06:52 UTC by Sachin Ghai
Modified: 2019-09-26 13:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-11 12:26:59 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Add Content View button is enabled when no cv is selected and on clicking UI raised notification (47.46 KB, image/png)
2014-05-07 06:52 UTC, Sachin Ghai 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 6390 0 None None None 2016-04-22 15:39:56 UTC

Description Sachin Ghai 2014-05-07 06:52:40 UTC 
Created attachment 893123 [details]
Add Content View button is enabled when no cv is selected and on clicking UI raised notification

Description of problem:
UI shows 'Add Content-View' button to add selected CV to composite-view. But the button remains enabled, when there is no CV to add or even the listed CV is un-selected. 

Similar behaviour with 'Remove Content View' button

Also, if you click on that button, without selecting any CV, UI raised a notification: Content-view updated.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. create a composite-view
2. select 'content-view' tab
3. click on 'Add' tab
4. click on 'Add Content View' button
5. Now click on 'List/Remove' tab
6. click on 'Remove Content View button

Actual results:
1. The buttons (Add Content View and Remove Content View) remains enabled, when there is no CV to add or even the listed CV is un-selected. Also UI raised a notification: "Content View updated" on clicking those buttons

Expected results:
The buttons (Add Content View and Remove Content View) should be disabled, when there is no CV to add or even the listed CV is un-selected.

Additional info:
Comment 1 RHEL Program Management 2014-05-07 07:05:14 UTC 
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.
Comment 3 Brad Buckingham 2014-06-25 14:17:22 UTC 
This issue describes a behavior that exists throughout the UI for the Add & List/Remove pages.  I tend to agree that it makes sense to disable the action buttons when a user hasn't selected anything in the list; therefore, I am devel_acking the bug; however, as part of investigating the solution, we should confirm if this is something that UX has indicated not to do.
Comment 4 Walden Raines 2014-06-25 15:39:33 UTC 
Created redmine issue http://projects.theforeman.org/issues/6390 from this bug
Comment 5 Walden Raines 2014-06-25 17:56:44 UTC 
PR:  https://github.com/Katello/katello/pull/4348
Comment 6 Walden Raines 2014-07-02 14:02:52 UTC 
commit 8b3b048f34e9554104f0d5ce66b2215e8ac5ee17
Merge: 76b7bfc 1e80722
Author: Walden Raines <walden>
Date:   Wed Jul 2 10:02:24 2014 -0400

    Merge pull request #4348 from waldenraines/6390
    
    Fixes #6390/BZ1095098 - disabled table actions if no rows are selected.

commit 1e80722fe4fdd2481759e5450cdbca953d75f8c3
Author: Walden Raines <walden>
Date:   Wed Jun 25 13:51:28 2014 -0400

    Fixes #6390/BZ1095098 - disabled table actions if no rows are selected.
    
    This commit disables all table actions across the application if
    no rows are selected.
Comment 8 sthirugn@redhat.com 2014-09-03 19:56:32 UTC 
Verified.

Version Tested:
GA Snap 7 - Satellite-6.0.4-RHEL-6-20140829.0

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.23-1.el6_5.noarch
* candlepin-common-1.0.1-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.23-1.el6_5.noarch
* candlepin-tomcat6-0.9.23-1.el6_5.noarch
* elasticsearch-0.90.10-6.el6sat.noarch
* foreman-1.6.0.42-1.el6sat.noarch
* foreman-compute-1.6.0.42-1.el6sat.noarch
* foreman-gce-1.6.0.42-1.el6sat.noarch
* foreman-libvirt-1.6.0.42-1.el6sat.noarch
* foreman-ovirt-1.6.0.42-1.el6sat.noarch
* foreman-postgresql-1.6.0.42-1.el6sat.noarch
* foreman-proxy-1.6.0.30-1.el6sat.noarch
* foreman-selinux-1.6.0.14-1.el6sat.noarch
* foreman-vmware-1.6.0.42-1.el6sat.noarch
* katello-1.5.0-30.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.6-1.el6sat.noarch
* katello-installer-0.0.62-1.el6sat.noarch
* openldap-2.4.23-34.el6_5.1.x86_64
* openldap-devel-2.4.23-34.el6_5.1.x86_64
* pulp-katello-0.3-4.el6sat.noarch
* pulp-nodes-common-2.4.1-0.5.rc1.el6sat.noarch
* pulp-nodes-parent-2.4.1-0.5.rc1.el6sat.noarch
* pulp-puppet-plugins-2.4.1-0.5.rc1.el6sat.noarch
* pulp-puppet-tools-2.4.1-0.5.rc1.el6sat.noarch
* pulp-rpm-plugins-2.4.1-0.5.rc1.el6sat.noarch
* pulp-selinux-2.4.1-0.5.rc1.el6sat.noarch
* pulp-server-2.4.1-0.5.rc1.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch
Comment 9 Bryan Kearney 2014-09-11 12:26:59 UTC 
This was delivered with Satellite 6.0 which was released on 10 September 2014.
Note You need to log in before you can comment on or make changes to this bug.