Spec URL: http://jjames.fedorapeople.org/opendial/opendial.spec SRPM URL: http://jjames.fedorapeople.org/opendial/opendial-0.95-1.fc21.src.rpm Fedora Account System Username: jjames Description: OpenDial is a Java-based software toolkit to facilitate the development of robust and adaptive spoken dialog systems. The toolkit itself is domain-independent and can be easily applied to any particular dialog domain. Dialog understanding, management and generation are expressed in OpenDial through probabilistic rules encoded in a simple XML format. In a nutshell, probabilistic rules are high-level templates for the construction of directed graphical models (i.e. Bayesian and decision networks) and are intended to combine the benefits of logical and statistical approaches to dialog modelling in a single framework. LICENSE NOTE: The code was recently changed from LGPLv2+ to MIT. See the 4/2/2014 entry under "News" on https://code.google.com/p/opendial/. Some of the files still contain an LGPL notice. I pointed this out to the author via private email, and received this response: Hi Jerry, Thanks a lot for your work packaging my software! And for informing me that some files still had the LGPL header, I didn’t notice that. It’s now changed on the development trunk. Pierre Therefore, the spec file marks the license as MIT.
Bundled parts: ./src/opendial/utils/AudioUtils.java have header: * This file is part of jsresources.org ./src/opendial/inference/approximate/SamplingProcess.java * @author Pierre Lison (plison.no)
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #1) > Bundled parts: > ./src/opendial/utils/AudioUtils.java have header: > * This file is part of jsresources.org Thanks, I will check into this one. > ./src/opendial/inference/approximate/SamplingProcess.java > * @author Pierre Lison (plison.no) Pierre Lison is the author of opendial.
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #1) > Bundled parts: > ./src/opendial/utils/AudioUtils.java have header: > * This file is part of jsresources.org jsresources.org has a collection of sample code for using the Java Sound API. It is intended to illustrate usage of various parts of the API to code authors. In this case, the upstream example code has been modified quite a bit by the opendial author. In that case (it is not vanilla upstream code, and the upstream code is not intended to be production code anyway), I believe the code does not run afoul of the no-bundling rule.
It is a good. But will be best if that files archive standard license headers similar to other files in project. Off course it is just should not must.
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.SFYHhK + umask 022 + cd /builddir/build/BUILD + cd opendial + ant test Buildfile: /builddir/build/BUILD/opendial/build.xml init: compile: test-run: [mkdir] Created dir: /builddir/build/BUILD/opendial/doc/testreports [junit] Running opendial.bn.AssignmentTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.234 sec [junit] Running opendial.bn.BNetworkStructureTest [junit] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.181 sec [junit] Test opendial.bn.BNetworkStructureTest FAILED [junit] Running opendial.bn.DistributionsTest [junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.91 sec [junit] Running opendial.bn.ValueTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.097 sec [junit] Running opendial.domains.BasicRuleTest [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.644 sec [junit] Running opendial.domains.BasicRuleTest2 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.581 sec [junit] Running opendial.domains.DemoTest [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.538 sec [junit] Test opendial.domains.DemoTest FAILED [junit] Running opendial.domains.DialogueStateTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.972 sec [junit] Running opendial.domains.LearningTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.706 sec [junit] Running opendial.domains.OutputsTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.104 sec [junit] Running opendial.domains.ParametersTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.272 sec [junit] Running opendial.domains.PredictionTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.121 sec [junit] Running opendial.domains.PruningTest [junit] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.527 sec [junit] Running opendial.domains.QuantificationTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.183 sec [junit] Running opendial.domains.StepByStepTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.196 sec [junit] Running opendial.domains.TemplateStringTest [junit] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.262 sec [junit] Running opendial.inference.IncrementalTest [junit] Tests run: 3, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 0.7 sec [junit] Test opendial.inference.IncrementalTest FAILED [junit] Running opendial.inference.InferenceLargeScaleTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.089 sec [junit] Running opendial.inference.InferenceTest [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.117 sec [junit] Running opendial.inference.NetworkReductionTest [junit] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.097 sec [junit] Test opendial.inference.NetworkReductionTest FAILED [junit] Running opendial.modules.ImporterTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.178 sec [junit] Running opendial.modules.PlanningTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.996 sec [junit] Running opendial.modules.RecordingTest [junit] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.035 sec [junit] Test opendial.modules.RecordingTest FAILED [junit] Running opendial.modules.SimulatorTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.203 sec [junit] Running opendial.modules.WizardTest [junit] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 6.728 sec [junit] Test opendial.modules.WizardTest FAILED test-report: [junitreport] Processing /builddir/build/BUILD/opendial/doc/testreports/TESTS-TestSuites.xml to /tmp/null1768345105 [junitreport] Loading stylesheet jar:file:/usr/share/java/ant/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl [junitreport] Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. [junitreport] Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. [junitreport] Transform time: 1569ms [junitreport] Deleting: /tmp/null1768345105 test: BUILD SUCCESSFUL Tests failed, but exit code is 0. It must be fixed both: 1) Return code should be not 0 if it failed. 2) Try fix failed tests with upstream author. If you are unable fix (for example doe to network activity) may be disable some.
hi URL and Source0 field should be changed in: URL: http://www.opendial-toolkit.net/ Source0: https://github.com/plison/opendial/archive/version-0.95.tar.gz available newer release: 1.4 (consider upgrading)
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.