Spec URL: http://cycloptivity.fedorapeople.org/drupal7-block_class/2.1-1/drupal7-block_class.spec SRPM URL: http://cycloptivity.fedorapeople.org/drupal7-block_class/2.1-1/drupal7-block_class-2.1-1.fc19.src.rpm Description: Block Class allows users to add classes via block configuration interface Fedora Account System Username: cycloptivity Scratch build output http://koji.fedoraproject.org/koji/taskinfo?taskID=6825538
Review: + Package builds successful in F21 x86_64 mock + rpmlint on generated rpms gave drupal7-block_class.noarch: W: spelling-error %description -l en_US tpl -> pl, tel, til drupal7-block_class.noarch: W: spelling-error %description -l en_US php -> pp, hp, pep drupal7-block_class.src: W: spelling-error %description -l en_US tpl -> pl, tel, til drupal7-block_class.src: W: spelling-error %description -l en_US php -> pp, hp, pep 2 packages and 0 specfiles checked; 0 errors, 4 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 78b5c6b448087261045421546b9d919fa48556051b8f5202053e8c55754d6341 upstream tarball : 78b5c6b448087261045421546b9d919fa48556051b8f5202053e8c55754d6341 + License is valid GPLv2+ and included in its own text file LICENSE.txt + Package follows drupal7 packaging guidelines Suggestions: 1) Group tag is not necessary in Fedora now and can be removed from spec file. See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag APPROVED this package review.
This review bug summary should match with the summary written in spec file.
(In reply to Parag AN(पराग) from comment #1) > Suggestions: > 1) Group tag is not necessary in Fedora now and can be removed from spec > file. See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag Drupal 7 packaging guidelines template (https://fedoraproject.org/wiki/Packaging:Drupal7#Module) has the Group tag. Per overall packaging guidelines (https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag) it can stay to be compatible with EPEL and all Drupal pkgs are packaged for EPEL. Additional item (since this pkg is already approved, please update after initial import): 2) "Requires: php(language) >= 5.0" not required and should not be present. You do need to run phpcompatinfo on the module though -- see https://fedoraproject.org/wiki/Packaging:Drupal7#PHP_Extensions
thanks Shawn for your suggestion. If this is going to be packaged for EPEL then group tag, buildroot can stay.
New Package SCM Request ======================= Package Name: drupal7-block_class Short Description: Block Class allows users to add classes via block configuration interface Upstream URL: http://drupal.org/project/block_class Owners: cycloptivity anross asrob siwinski Branches: f19 f20 el6 epel7 InitialCC:
anross is not in the packager group.
New Package SCM Request ======================= Package Name: drupal7-block_class Short Description: Block Class allows users to add classes via block configuration interface Upstream URL: http://drupal.org/project/block_class Owners: cycloptivity asrob siwinski Branches: f19 f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
drupal7-block_class-2.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/drupal7-block_class-2.1-1.fc20
drupal7-block_class-2.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/drupal7-block_class-2.1-1.el7
drupal7-block_class-2.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/drupal7-block_class-2.1-1.fc19
drupal7-block_class-2.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal7-block_class-2.1-1.el6
I got the permission from this package submitter to build his packages. I see this package missed f21 branch please create it. Package Change Request ======================= Package Name: drupal7-block_class New Branches: f21 Owners: cycloptivity asrob siwinski
drupal7-block_class-2.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
drupal7-block_class-2.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/drupal7-block_class-2.1-1.fc21
drupal7-block_class-2.1-1.fc20 has been pushed to the Fedora 20 stable repository.
drupal7-block_class-2.1-1.fc19 has been pushed to the Fedora 19 stable repository.
drupal7-block_class-2.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
drupal7-block_class-2.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
drupal7-block_class-2.1-1.fc21 has been pushed to the Fedora 21 stable repository.