Bug 1095595 - Stick to IANA standard while allocating brick ports
Summary: Stick to IANA standard while allocating brick ports
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: protocol
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: krishnan parthasarathi
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: glusterfs-3.5.2
TreeView+ depends on / blocked
 
Reported: 2014-05-08 06:05 UTC by Joe Julian
Modified: 2015-11-03 23:06 UTC (History)
8 users (show)

Fixed In Version: glusterfs-3.5.1
Doc Type: Bug Fix
Doc Text:
Clone Of: 824233
Environment:
Last Closed: 2014-07-13 12:04:58 UTC
Regression: ---
Mount Type: ---
Documentation: DP
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Joe Julian 2014-05-08 06:05:55 UTC
This change needs documented in doc/admin-guide/en-US/markdown/admin_monitoring_workload.md, doc/admin-guide/en-US/markdown/admin_settingup_clients.md, and doc/glusterfsd.8

+++ This bug was initially created as a clone of Bug #824233 +++

Description of problem:
Ref: RFC 6335
Use ports above 49152 for bricks as they are in the private range.

--- Additional comment from Amar Tumballi on 2012-05-24 23:49:20 EDT ---

fixed by patch http://review.gluster.com/3339

--- Additional comment from Amar Tumballi on 2012-06-01 02:54:01 EDT ---

the bug fix is only in upstream, not in release-3.3. Hence moving it out of the ON_QA, and setting MODIFIED (as a standard practice @ Red Hat)

--- Additional comment from Joe Julian on 2014-05-08 02:01:39 EDT ---

This change lacks documentation.

Comment 1 Anand Avati 2014-05-22 17:38:59 UTC
REVIEW: http://review.gluster.org/7853 (doc: Fix peer probe deficiencies) posted (#1) for review on release-3.5 by Joe Julian (me)

Comment 2 Anand Avati 2014-05-23 04:49:17 UTC
REVIEW: http://review.gluster.org/7855 (doc: fix brick port ranges in admin guide.) posted (#1) for review on master by Krishnan Parthasarathi (kparthas)

Comment 3 Anand Avati 2014-05-23 12:31:29 UTC
REVIEW: http://review.gluster.org/7855 (doc: fix brick port ranges in admin guide.) posted (#2) for review on master by Krishnan Parthasarathi (kparthas)

Comment 4 Anand Avati 2014-05-23 14:47:22 UTC
COMMIT: http://review.gluster.org/7855 committed in master by Niels de Vos (ndevos) 
------
commit 1d8ad8a993a256155032787b34f16d07843482ef
Author: Krishnan Parthasarathi <kparthas>
Date:   Fri May 23 10:18:35 2014 +0530

    doc: fix brick port ranges in admin guide.
    
    Change-Id: Ie6ac43ea435b7b21ac2b7975cbfe38126b170100
    BUG: 1095595
    Signed-off-by: Krishnan Parthasarathi <kparthas>
    Reviewed-on: http://review.gluster.org/7855
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>

Comment 5 Anand Avati 2014-05-23 19:55:35 UTC
REVIEW: http://review.gluster.org/7853 (doc: Fix peer probe deficiencies) posted (#2) for review on release-3.5 by Joe Julian (me)

Comment 6 Anand Avati 2014-05-28 11:46:33 UTC
REVIEW: http://review.gluster.org/7910 (doc: fix brick port ranges in admin guide.) posted (#1) for review on release-3.5 by Krishnan Parthasarathi (kparthas)

Comment 7 Anand Avati 2014-05-28 11:55:24 UTC
COMMIT: http://review.gluster.org/7910 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit fed8145a9e3bafa6cc326bf7487940791b2efb30
Author: Krishnan Parthasarathi <kparthas>
Date:   Fri May 23 10:18:35 2014 +0530

    doc: fix brick port ranges in admin guide.
    
    Change-Id: Ie6ac43ea435b7b21ac2b7975cbfe38126b170100
    BUG: 1095595
    Signed-off-by: Krishnan Parthasarathi <kparthas>
    Reviewed-on: http://review.gluster.org/7855
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/7910

Comment 8 Niels de Vos 2014-06-10 09:48:36 UTC
This bug is partially addressed, not moving to MODIFIED, but rescheduling for 3.5.2.

Next steps:
- send a patch like http://review.gluster.org/7853 for the master branch
- have the master branch patch reviewed, verified and merged
- leave a comment in http://review.gluster.org/7853 mentioning the merging of the 
  master branch patch
- poke me to merge the 3.5 version of the patch


Joe, do you want to send the patch for the master branch, or do you want someone else to take care of that?

Comment 9 Anand Avati 2014-06-14 00:54:17 UTC
REVIEW: http://review.gluster.org/7853 (doc: Fix peer probe deficiencies) posted (#3) for review on release-3.5 by Joe Julian (me)

Comment 10 Anand Avati 2014-06-14 00:55:30 UTC
REVIEW: http://review.gluster.org/7853 (doc: Fix peer probe deficiencies) posted (#4) for review on release-3.5 by Joe Julian (me)


Note You need to log in before you can comment on or make changes to this bug.