Bug 1095923 - Review Request: R-expm - Computation of the matrix exponential and related quantities
Summary: Review Request: R-expm - Computation of the matrix exponential and related qu...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pierre-YvesChibon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-08 20:33 UTC by Tom "spot" Callaway
Modified: 2014-08-25 10:02 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-08-25 10:02:30 UTC
Type: ---
Embargoed:
pingou: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2014-05-08 20:33:41 UTC
Spec URL: http://spot.fedorapeople.org/R-expm.spec
SRPM URL: http://spot.fedorapeople.org/R-expm-0.99.1.1-1.fc20.src.rpm
Description: Efficient calculation of the exponential of a matrix. The package
contains an R interface and a C API that package authors can use.
Fedora Account System Username: spot
Rawhide Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6827955

Note: This is a new BuildRequires/Requires for R-msm 1.3. It will only go into F20 and rawhide, unless there is a need for it in f19.

Comment 1 Pierre-YvesChibon 2014-05-12 08:01:47 UTC
* Spec is clean
* License is GPLv2+
! In the sources, three files (src/expm.c, src/logm-eigen.c and src/expm-eigen.c) have the following header:

 *  The functions therein use LAPACK and BLAS routines. Nicely
 *  formatted man pages for these can be found at
 *
 *    <http://www.mathkeisan.com/UsersGuide/E/>
 *
 *  AUTHORS: Christophe Dutang, based on code eigen,
 *
 *  i.e., function 'modLa_rg' and 'modLa_dgesv' in R's
 *  <Rsource>/src/modules/lapack/lapack.c, used in eigen()

Could these be bundled? I did not check if they have been changed or not

* Builds errors on F20:

Warning: Nonexistent include directory "/usr/lib64/gfortran/modules"
gcc -m64 -std=gnu99 -shared -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -flto -fpic -Wl,-z,relro -o expm.so R_dgebal.o expm-eigen.o expm.o init.o logm-eigen.o matexp.o matpow.o matrexp.o matrexpO.o mexp-common.o -llapack -lblas -lgfortran -lm -lquadmath -lgfortran -lm -lquadmath -L/usr/lib64/R/lib -lR
/usr/bin/ld: cannot find -llapack
/usr/bin/ld: cannot find -lblas
collect2: error: ld returned 1 exit status
make: *** [expm.so] Error 1
ERROR: compilation failed for package 'expm'

* rpmlint:
rpmlint R-expm-0.99.1.1-1.fc20.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

* sha512sum expm_0.99-1.1.tar.gz (upstream)
89c7728abb6ce8ec9fa86519e35be2c90f1381f4a5421e9e959c0900bb9a41805145059eb6fd175eb22d5510ecee7ad35b9abb4937c0f406c6acef82db3270c5  expm_0.99-1.1.tar.gz
sha512sum R-expm-0.99.1.1-1.fc20.src/expm_0.99-1.1.tar.gz  (src.rpm)
89c7728abb6ce8ec9fa86519e35be2c90f1381f4a5421e9e959c0900bb9a41805145059eb6fd175eb22d5510ecee7ad35b9abb4937c0f406c6acef82db3270c5  R-expm-0.99.1.1-1.fc20.src/expm_0.99-1.1.tar.gz


So we have to see about the headers and whether you want the F20 branch or not :)

Comment 2 Tom "spot" Callaway 2014-05-12 14:54:18 UTC
The linking errors are because the latest R update which has Requires: lapack-devel, blas-devel on R-devel hasn't hit stable yet.

src/expm.c uses a modified version of expm from Matrix, and calls out to LAPACK/BLAS. That's pretty much the point of R-expm. ;) It would not be possible to use the expm from Matrix here.

src/logm-eigen.c and src/expm-eigen.c have no bundling at all, just callouts to LAPACK/BLAS functions.

I conclude there is no bundling concern here, but if you want me to get in the FPC queue, I shall. :)

Comment 3 Pierre-YvesChibon 2014-05-12 15:39:21 UTC
> The linking errors are because the latest R update which has Requires: lapack-
> devel, blas-devel on R-devel hasn't hit stable yet.

Should we add a minimal version required then?

I trust we can do that before import into git.

Thanks for checking the sources, I will spare you adding it to the FPC queue :)


This package is APPROVED.

Comment 4 Tom "spot" Callaway 2014-05-12 18:04:49 UTC
New Package SCM Request
=======================
Package Name: R-expm
Short Description: Computation of the matrix exponential and related quantities
Owners: spot
Branches: f20
InitialCC:

Comment 5 Gwyn Ciesla 2014-05-12 19:51:52 UTC
Git done (by process-git-requests).

Comment 6 Pierre-YvesChibon 2014-06-10 06:50:10 UTC
built? Should we close this one?


Note You need to log in before you can comment on or make changes to this bug.