Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1096017

Summary:

[RFE] add or logic to support complicated hostrequire

Product:

[Retired] Beaker

Reporter:

Zhenjie Chen <zhchen>

Component:

command line

Assignee:

beaker-dev-list

Status:

CLOSED WONTFIX

QA Contact:

tools-bugs <tools-bugs>

Severity:

medium

Docs Contact:

Priority:

high

Version:

0.16

CC:

aigao, asaha, dcallagh, haliu, jiyin, kzhang, mgahagan, rmancy, zshi

Target Milestone:

---

Keywords:

FutureFeature, Patch

Target Release:

---

Hardware:

Unspecified

OS:

Unspecified

Whiteboard:

Fixed In Version:

Doc Type:

Enhancement

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2014-05-12 02:35:00 UTC

Type:

Bug

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
0001-add-or-logic-to-support-complicated-hostrequire.patch	none

Comment 1 Dan Callaghan 2014-05-11 22:37:48 UTC

Thanks for your suggestions and your patch.

Coincidentally just last week I implemented bug 1014693, which allows you to pass raw XML to --hostrequire, for example:

bkr workflow-simple --hostrequire '<or> <hostname op="=" value="machine1.example.com"/> <hostname op="=" value="machine2.example.com"/> </or>' ...

I think for complicated host requirements this is a better approach because it lets you arbitrarily nest <and/> and <or/>. You can take full advantage of the XML filtering syntax, instead of approximating it with command-line options.

What do you think?

Comment 2 Zhenjie Chen 2014-05-12 01:24:10 UTC

Hi Dan,

Yes, I like your solution, it's better. Thanks for your work.