Bug 1096184 - Review Request: nodejs-i18n-transform - i18n transforms to a json object
Summary: Review Request: nodejs-i18n-transform - i18n transforms to a json object
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-09 11:31 UTC by anish
Modified: 2015-04-12 23:12 UTC (History)
3 users (show)

Fixed In Version: nodejs-i18n-transform-1.1.1-1.el6
Clone Of:
Environment:
Last Closed: 2014-08-08 08:41:12 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description anish 2014-05-09 11:31:06 UTC
Spec URL: http://anishpatil.fedorapeople.org/nodejs-i18n-transform.spec
SRPM URL: http://anishpatil.fedorapeople.org/nodejs-i18n-transform-1.0.1-1.fc20.src.rpm
Description: 
i18n transforms to a json object

Fedora Account System Username: anishpatil

Comment 1 Parag AN(पराग) 2014-07-19 12:58:19 UTC
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-i18n-transform.noarch: W: spelling-error Summary(en_US) json -> son, j son
nodejs-i18n-transform.noarch: W: summary-not-capitalized C i18n transforms to a json object.
nodejs-i18n-transform.noarch: W: summary-ended-with-dot C i18n transforms to a json object.
nodejs-i18n-transform.noarch: W: spelling-error %description -l en_US json -> son, j son
nodejs-i18n-transform.noarch: W: only-non-binary-in-usr-lib
nodejs-i18n-transform.src: W: spelling-error Summary(en_US) json -> son, j son
nodejs-i18n-transform.src: W: summary-not-capitalized C i18n transforms to a json object.
nodejs-i18n-transform.src: W: summary-ended-with-dot C i18n transforms to a json object.
nodejs-i18n-transform.src: W: spelling-error %description -l en_US json -> son, j son
2 packages and 0 specfiles checked; 0 errors, 9 warnings.

==> Fix the summary related warnings

+ Source verified with upstream as (sha256sum)
srpm tarball     :78bd08a2aa061fe6dd8ab087a9e7ac59b61a8ce155055ddd0eb89a031e95307a
upstream tarball :78bd08a2aa061fe6dd8ab087a9e7ac59b61a8ce155055ddd0eb89a031e95307a

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines


Suggestions:
1) you can drop Group tag for Fedora releases.

2) Package is missing
Requires: npm(hoek)

3) we don't have updated nodejs-hoek in Fedora so need to fix its version. Use in %prep
%nodejs_fixdep hoek

4) %check should be added as before %files as

%check
%if 0%{?enable_tests}
grunt test
%endif

Comment 2 anish 2014-07-22 12:44:34 UTC
Thanks Parag for review comments,please find updated spec below:-

Spec URL: http://anishpatil.fedorapeople.org/nodejs-i18n-transform.spec

SRPM URL: http://anishpatil.fedorapeople.org/nodejs-i18n-transform-1.0.1-2.fc20.src.rpm

Comment 3 Parag AN(पराग) 2014-07-23 08:16:10 UTC
Its good to add following in %install
 %nodejs_symlink_deps

Otherwise all is good now.


APPROVED.

Comment 4 anish 2014-07-24 11:07:14 UTC
Thanks Parag for review 

New Package SCM Request
=======================
Package Name: nodejs-i18n-transform 
Short Description: i18n transforms to a json objec
Upstream URL:  https://github.com/andyroyle/i18n-transform
Owners: anishpatil
Branches: f20 f21 
InitialCC: i18n-team

Comment 5 Gwyn Ciesla 2014-07-24 12:24:19 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-07-28 09:08:49 UTC
nodejs-i18n-transform-1.0.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-i18n-transform-1.0.1-2.fc20

Comment 7 Fedora Update System 2014-07-29 02:07:42 UTC
Package nodejs-i18n-transform-1.0.1-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nodejs-i18n-transform-1.0.1-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-8933/nodejs-i18n-transform-1.0.1-2.fc20
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2014-08-08 08:41:12 UTC
nodejs-i18n-transform-1.0.1-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 anish 2014-12-08 06:25:04 UTC
Package Change Request
======================
Package Name: nodejs-i18n-transform 
New Branches: el6 epel7 
Owners: anishpatil
InitialCC: i18n-team

Comment 10 Gwyn Ciesla 2014-12-08 13:49:06 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-12-09 06:17:56 UTC
nodejs-i18n-transform-1.1.1-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-i18n-transform-1.1.1-1.el7

Comment 12 Fedora Update System 2014-12-09 06:18:03 UTC
nodejs-i18n-transform-1.1.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/nodejs-i18n-transform-1.1.1-1.el6

Comment 13 Fedora Update System 2014-12-26 19:51:12 UTC
nodejs-i18n-transform-1.1.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 14 Fedora Update System 2014-12-26 19:51:41 UTC
nodejs-i18n-transform-1.1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.