Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://anishpatil.fedorapeople.org/nodejs-i18n-transform.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-i18n-transform-1.0.1-1.fc20.src.rpm Description: i18n transforms to a json object Fedora Account System Username: anishpatil
Review: + mock build is successful for f22 - rpmlint output on rpms gave nodejs-i18n-transform.noarch: W: spelling-error Summary(en_US) json -> son, j son nodejs-i18n-transform.noarch: W: summary-not-capitalized C i18n transforms to a json object. nodejs-i18n-transform.noarch: W: summary-ended-with-dot C i18n transforms to a json object. nodejs-i18n-transform.noarch: W: spelling-error %description -l en_US json -> son, j son nodejs-i18n-transform.noarch: W: only-non-binary-in-usr-lib nodejs-i18n-transform.src: W: spelling-error Summary(en_US) json -> son, j son nodejs-i18n-transform.src: W: summary-not-capitalized C i18n transforms to a json object. nodejs-i18n-transform.src: W: summary-ended-with-dot C i18n transforms to a json object. nodejs-i18n-transform.src: W: spelling-error %description -l en_US json -> son, j son 2 packages and 0 specfiles checked; 0 errors, 9 warnings. ==> Fix the summary related warnings + Source verified with upstream as (sha256sum) srpm tarball :78bd08a2aa061fe6dd8ab087a9e7ac59b61a8ce155055ddd0eb89a031e95307a upstream tarball :78bd08a2aa061fe6dd8ab087a9e7ac59b61a8ce155055ddd0eb89a031e95307a + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines Suggestions: 1) you can drop Group tag for Fedora releases. 2) Package is missing Requires: npm(hoek) 3) we don't have updated nodejs-hoek in Fedora so need to fix its version. Use in %prep %nodejs_fixdep hoek 4) %check should be added as before %files as %check %if 0%{?enable_tests} grunt test %endif
Thanks Parag for review comments,please find updated spec below:- Spec URL: http://anishpatil.fedorapeople.org/nodejs-i18n-transform.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-i18n-transform-1.0.1-2.fc20.src.rpm
Its good to add following in %install %nodejs_symlink_deps Otherwise all is good now. APPROVED.
Thanks Parag for review New Package SCM Request ======================= Package Name: nodejs-i18n-transform Short Description: i18n transforms to a json objec Upstream URL: https://github.com/andyroyle/i18n-transform Owners: anishpatil Branches: f20 f21 InitialCC: i18n-team
Git done (by process-git-requests).
nodejs-i18n-transform-1.0.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-i18n-transform-1.0.1-2.fc20
Package nodejs-i18n-transform-1.0.1-2.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nodejs-i18n-transform-1.0.1-2.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-8933/nodejs-i18n-transform-1.0.1-2.fc20 then log in and leave karma (feedback).
nodejs-i18n-transform-1.0.1-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: nodejs-i18n-transform New Branches: el6 epel7 Owners: anishpatil InitialCC: i18n-team
nodejs-i18n-transform-1.1.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-i18n-transform-1.1.1-1.el7
nodejs-i18n-transform-1.1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-i18n-transform-1.1.1-1.el6
nodejs-i18n-transform-1.1.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
nodejs-i18n-transform-1.1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.