Description: The NGram class extends the Python 'set' class with efficient fuzzy search for members by means of an N-gram similarity measure. It also has static methods to compare a pair of strings. The N-grams are character based not word-based, and the class does not implement a language model, merely searching for members by string similarity. Koji Builds: el5: no build ---> needs Python >= 2.5 el6: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831187 epel7: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831189 F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831191 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831193 Frh: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831195 Issues: fedora-review shows no obvious issues. rpmlint complains about a missing manpage. FAS-User: besser82 Urls: Spec URL: http://besser82.fedorapeople.org/review/python-ngram.spec SRPM URL: http://besser82.fedorapeople.org/review/python-ngram-3.3.0-1.fc20.src.rpm Thanks for review in advance!
Fixed / updated some minor glitch in spec-file. Spec-file and SRPM were updated in-place. New Koji Builds: el5: no build ---> needs Python >= 2.5 el6: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831327 epel7: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831329 F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831332 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831335 Frh: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831339
Review done, looks fine! Greetings, Christian Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* LGPL (v3 or later)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/rpmbuild/1096188-python-ngram/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- ngram-doc , python3-ngram [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-ngram-3.3.0-1.fc21.noarch.rpm python-ngram-doc-3.3.0-1.fc21.noarch.rpm python3-ngram-3.3.0-1.fc21.noarch.rpm python-ngram-3.3.0-1.fc21.src.rpm python-ngram.noarch: W: no-manual-page-for-binary csvjoin 4 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python3-ngram python-ngram python-ngram-doc python-ngram.noarch: W: no-manual-page-for-binary csvjoin 3 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- python3-ngram (rpmlib, GLIBC filtered): python(abi) python-ngram (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-ngram-doc (rpmlib, GLIBC filtered): Provides -------- python3-ngram: python3-ngram python-ngram: python-ngram python-ngram-doc: python-ngram-doc Source checksums ---------------- https://github.com/gpoulter/python-ngram/archive/3.3.0.tar.gz#/python-ngram-3.3.0.tar.gz : CHECKSUM(SHA256) this package : 5787f21df9422ecba88f07a008f2b1383d41e09e99d933a2b51f3d5b9d23382d CHECKSUM(SHA256) upstream package : 5787f21df9422ecba88f07a008f2b1383d41e09e99d933a2b51f3d5b9d23382d Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1096188 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Many thanks for the quick review, Christian! :D ##### New Package SCM Request ======================= Package Name: python-ngram Short Description: Set-based subclass providing fuzzy search based on N-grams Owners: besser82 Branches: el6 epel7 f19 f20 InitialCC: ml-sig
Git done (by process-git-requests).
python-ngram-3.3.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-ngram-3.3.0-1.el6
python-ngram-3.3.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-ngram-3.3.0-1.fc19
python-ngram-3.3.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-ngram-3.3.0-1.fc20
python-ngram-3.3.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
python-ngram-3.3.0-1.fc20 has been pushed to the Fedora 20 stable repository.
python-ngram-3.3.0-1.fc19 has been pushed to the Fedora 19 stable repository.
python-ngram-3.3.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.