Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-JSON-MaybeXS/branches/fedora/perl-JSON-MaybeXS.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-JSON-MaybeXS/perl-JSON-MaybeXS-1.002002-2.fc21.src.rpm Description: This module first checks to see if either Cpanel::JSON::XS or JSON::XS is already loaded, in which case it uses that module. Otherwise it tries to load Cpanel::JSON::XS, then JSON::XS, then JSON::PP in order, and either uses the first module it finds or throws an error. It then exports the "encode_json" and "decode_json" functions from the loaded module, along with a "JSON" constant that returns the class name for calling "new" on. If you're writing fresh code rather than replacing JSON.pm usage, you might want to pass options as constructor args rather than calling mutators, so we provide our own "new" method that supports that. Fedora Account System Username: pghmcfc Note: this package takes the approach of adding a hard dependency on upstream's preferred back-end, Cpanel::JSON::XS, rather than using a virtual provides/requires arrangement so that any of the supported back-ends could be used. This is not only much simpler and does not involve modifications to the back-end packages, but it also makes for consistent results as we're always using the same, most-tested back-end.
Taking this one
Licensing is correct BuildRoot can be removed (all the EL5 tags has been cleaned up) Spec and SRPM are slightly different. Diff spec file in url and in SRPM --------------------------------- --- /home/makerpm/1096264-perl-JSON-MaybeXS/srpm/perl-JSON-MaybeXS.spec 2014-05-10 10:09:23.206049415 +1000 +++ /home/makerpm/1096264-perl-JSON-MaybeXS/srpm-unpacked/perl-JSON-MaybeXS.spec 2014-05-09 23:55:55.000000000 +1000 @@ -79,5 +79,5 @@ - Update to 1.002002 - More metadata fiddling, to remove the Cpanel::JSON::XS dependency visible - to static analyzers (the prerequisites at install time remain unchanged) + to static analyzers (the prequisites at install time remain unchanged) * Wed Apr 23 2014 Paul Howarth <paul> - 1.002001-1 Require: Exporter should be added as the "use base qw(Exporter)" syntax is not correctly auto detected rpmlint incorrectly complains about spelling errors. # Note: this package takes the approach of adding a hard dependency on # upstream's preferred back-end, Cpanel::JSON::XS, rather than using # a virtual provides/requires arrangement so that any of the supported # back-ends could be used. This is not only much simpler and does not # involve modifications to the back-end packages, but it also makes for # consistent results as we're always using the same, most-tested # back-end. Agreed. Cpanel::JSON::XS is the preferred dependency of the author. # Test Suite (wants JSON::PP ≥ 2.27202 really but EL-6 doesn't have that) No problems as above. EL6 builds and tests fine at at http://koji.fedoraproject.org/koji/taskinfo?taskID=6833571 Package APPROVED
New Package SCM Request ======================= Package Name: perl-JSON-MaybeXS Short Description: Use Cpanel::JSON::XS with a fallback to JSON::XS and JSON::PP Owners: pghmcfc Branches: f19 f20 el6 epel7 InitialCC: perl-sig Thanks for the review David. The spec file difference was due to a changelog typo I spotted after building all the packages, which I didn't think was worth a rebuild. I'll get rid of the BuildRoot tag prior to import.
Adding myself to the cc: since I need this package to update perl-Search-Elasticsearch in rawhide.
Git done (by process-git-requests).
perl-JSON-MaybeXS-1.002002-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-JSON-MaybeXS-1.002002-2.el6
perl-JSON-MaybeXS-1.002002-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-JSON-MaybeXS-1.002002-2.fc19
perl-JSON-MaybeXS-1.002002-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-JSON-MaybeXS-1.002002-2.fc20
perl-JSON-MaybeXS-1.002002-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
perl-JSON-MaybeXS-1.002002-2.fc20 has been pushed to the Fedora 20 stable repository.
perl-JSON-MaybeXS-1.002002-2.fc19 has been pushed to the Fedora 19 stable repository.
perl-JSON-MaybeXS-1.002002-2.el6 has been pushed to the Fedora EPEL 6 stable repository.