+++ This bug was initially created as a clone of Bug #1087697 +++
Description of problem:
the man page states:
--sig-proxy=true: Proxify all received signal to the process (even in non-tty mode)
But the real behavior is, that sig-proxy doesn't work when --tty=true. It should be mentioned in there, taht --sig-proxy is incompatible with --tty.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. man docker
man page says it works even in non-tty
man page warns that --tty can't be used with --sig-proxy
How to verify:
1. docker run --tty=true -i --rm fedora bash -c 'for NUM in `seq 1 64`; do trap "echo Received $NUM, ignoring..." $NUM; done; while :; do sleep 1; done'
2. ps -ax | grep docker
3. kill -SIGUSR1 $PID
4. (with --tty=true no signals are received, when you try the same with --tty=false, signals are proxified and messages are displayed)
--- Additional comment from Lokesh Mandvekar on 2014-04-15 02:11:48 EDT ---
Copying William (he recently got per subcommand manpages merged upstream).
this seems to be the case even in the latest manpage (I'm guessing this was inherited from the original manpage).
William, was there any discussion about this in your PR?
--- Additional comment from Lokesh Mandvekar on 2014-04-15 02:15:31 EDT ---
btw, the 0.10 rpm includes the latest manpages (should be in yum soon)
--- Additional comment from Lukas Doktor on 2014-04-15 04:45:55 EDT ---
Thanks for a quick reply. I tried the docker-io-0.10.0-2.fc20.x86_64 which says:
When set to true, proxify all received signals to the process
(even in non-tty mode). The default is true.
I'd really like to change it to "only in non-tty" with possible warning that --tty=true is incompatible with --sig-proxy.
--- Additional comment from William Henry on 2014-04-30 15:54:25 EDT ---
I go this text from upstream. I'll check.
--- Additional comment from William Henry on 2014-04-30 16:02:22 EDT ---
Lukas,according to the folks upstream, this is a bug in docker run and attach. It should be as the text suggests.
Can you file a bug upstream with docker? Here:
Please just take the information you posted above and post it there.
Thanks. Well spotted.
--- Additional comment from Lukas Doktor on 2014-05-02 04:02:01 EDT ---
This turns out to be a bug in docker and not in the man page.
I believe the conclusion was the --sig-proxy
should work with --tty
Neat! Glad we could do our part to help find it :D
Matt has this bug been fixed upstream? Is it fixed in docker-1.0.0-10.el7.x86_64
Upstream is looking at the pull request. It still needs some work before I would say it is done and ready for inclusion in RHEL builds - need comments on how to proceed with a potentially significant change.
Any update on this?
Lukas upstream closed this issue as being fixed in current docker-1.3.
Could you verify it, or comment on the github issue.
Hi Daniel, if I understand the PR it was rejected. I tested it on docker-1.3.0-5.el7.HTB.x86_64 with the same results as before; tty version doesn't proxify, non-tty version does. Man pages still claim it should work even in non-TTY mode:
Proxy received signals to the process (even in non-TTY mode).
SIGCHLD, SIGSTOP, and SIGKILL are not proxied. The default is
which is true, it does work even in non-TTY mode, but it does not work in TTY mode. So it's let's say confusing. Given the fact that upstream doesn't like to change this how about changing the sentence to `(only non-TTY mode)`?
That works for me. Michal can you make the PR?
Sure, will do. I've easily reproduced this. And the patch from Matthew fixes this correctly. It's pity they've dismissed it.
Fixed in docker-1.3.2