Bug 1096303 - Enable ppc64le and gdb
Summary: Enable ppc64le and gdb
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: gdb
Version: rawhide
Hardware: ppc64le
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Jan Kratochvil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F-ExcludeArch-ppc64le, PPC64LETracker
TreeView+ depends on / blocked
 
Reported: 2014-05-09 15:39 UTC by Brent Baude
Modified: 2014-05-09 19:31 UTC (History)
6 users (show)

Fixed In Version: gdb-7.7.1-11.fc21
Clone Of:
Environment:
Last Closed: 2014-05-09 19:31:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
gdb-7.7-add-ppc64le.patch (45.64 KB, patch)
2014-05-09 15:39 UTC, Brent Baude
no flags Details | Diff

Description Brent Baude 2014-05-09 15:39:31 UTC
Created attachment 894073 [details]
gdb-7.7-add-ppc64le.patch

ppc64le support for gdb went into upstream version 7.8.  But for now, I have a patch and trivial spec changes to enable ppc64le in gdb-7.7.  Please incorporate these into rawhide and nvr bump then.  If you prefer to conditionally apply the patch for the ppc64le arch only, I am ok with that too.

The following spec changes are needed.  Change as you prefer.  Ill attach the gdb-7.7-add-ppc64le.patch file.



diff --git a/gdb.spec b/gdb.spec
index 86cfade..5067cd9 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -539,6 +539,8 @@ Patch852: gdb-gnat-dwarf-crash-3of3.patch
 Patch865: gdb-static-tls-1of2.patch
 Patch866: gdb-static-tls-2of2.patch
 
+Patch999: gdb-7.7-add-ppc64le.patch
+
 %if 0%{!?rhel:1} || 0%{?rhel} > 6
 # RL_STATE_FEDORA_GDB would not be found for:
 # Patch642: gdb-readline62-ask-more-rh.patch
@@ -616,7 +618,7 @@ BuildRequires: systemtap-sdt-devel
 # Copied from prelink-0.4.2-3.fc13.
 %ifarch %{ix86} alpha sparc sparcv9 sparc64 s390 s390x x86_64 ppc ppc64
 # Prelink is broken on sparcv9/sparc64.
-%ifnarch sparc sparcv9 sparc64
+%ifnarch sparc sparcv9 sparc64 ppc64le
 BuildRequires: prelink
 %endif
 %endif
@@ -649,7 +651,7 @@ BuildRequires: glibc-static%{bits_local}
 # for gcc-java linkage:
 BuildRequires: zlib-devel%{bits_local} zlib-devel%{bits_other}
 # Copied from valgrind-3.5.0-1.
-%ifarch %{ix86} x86_64 ppc ppc64
+%ifarch %{ix86} x86_64 ppc ppc64 ppc64le
 BuildRequires: valgrind%{bits_local} valgrind%{bits_other}
 %endif
 %if 0%{!?rhel:1} || 0%{?rhel} > 6
@@ -921,7 +923,7 @@ export LDFLAGS="%{?__global_ldflags} %{?_with_asan:-fsanitize=addr
        --with-system-gdbinit=%{_sysconfdir}/gdbinit            \
        --with-gdb-datadir=%{_datadir}/gdb                      \
        --enable-gdb-build-warnings=,-Wno-unused                \
-%ifnarch %{ix86} alpha ppc s390 s390x x86_64 ppc64 sparc sparcv9 sparc64
+%ifnarch %{ix86} alpha ppc s390 s390x x86_64 ppc64 sparc sparcv9 sparc64 ppc64le
        --disable-werror                                        \
 %else
        --enable-werror                                         \

Comment 1 Brent Baude 2014-05-09 15:40:31 UTC
fyi I built gdb on the ppcle koji in case you are interested in poking at it:

http://ppc-le.koji.fedoraproject.org/koji/taskinfo?taskID=14767

Comment 2 Jan Kratochvil 2014-05-09 15:50:20 UTC
It would be better to point at the upstream commits - I will look them up.
The patch file is not acceptable.

Comment 3 Jan Kratochvil 2014-05-09 19:31:56 UTC
It is building now in primary Koji.
http://pkgs.fedoraproject.org/cgit/gdb.git/commit/?id=6e0665a33c841cb72f25624655a40e62747390ed


Note You need to log in before you can comment on or make changes to this bug.