Created attachment 894105 [details] qtwebkit-23-ppc64le.patch simplified patch Description of problem: qtwebkit enable jit for ppc64le Version-Release number of selected component (if applicable): qtwebkit-2.3.3-13.fc21 This bz is addressing two suggested changes: 1- simplify the qtwebkit-23-ppc64le.patch previously added by git commit "ppc64le support" http://pkgs.fedoraproject.org/cgit/qtwebkit.git/commit/?id=21d9fad3e3864a64dd81c23956ff2aff08ce9456 refer to new qtwebkit-23-ppc64le.patch provided as attachment for simplied patch. 2- update qtwebkit.spec to enable jit for ppc64le, as suggested by diff below. === diff --git a/qtwebkit.spec b/qtwebkit.spec index 0a557f3..d4ac984 100644 --- a/qtwebkit.spec +++ b/qtwebkit.spec @@ -166,7 +166,7 @@ PATH=%{_qt4_bindir}:$PATH; export PATH QMAKEPATH=`pwd`/Tools/qmake; export QMAKEPATH QTDIR=%{_qt4_prefix}; export QTDIR -%ifarch aarch64 ppc64le +%ifarch aarch64 %global qtdefines DEFINES+=ENABLE_JIT=0 DEFINES+=ENABLE_YARR_JIT=0 DEFINES+=ENABLE_ASSEMBLER=0 %endif === I was able to mock build for ppc64le, but do not know yet how to test qtwebkit.
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22
Sorry for the delay, I'll try to incorporate this today.
%changelog * Tue Mar 17 2015 Rex Dieter <rdieter> 2.3.4-3 - qtwebkit enable jit for ppc64le (#1096330)
Boo, looks like the supplied patch no longer applies against 2.3.4 + echo 'Patch #15 (qtwebkit-23-ppc64le.patch):' Patch #15 (qtwebkit-23-ppc64le.patch): + /usr/bin/cat /data/rdieter1/pkgs.fedoraproject.org/qtwebkit/qtwebkit-23-ppc64le.patch + /usr/bin/patch -p1 -b --suffix .ppc64le --fuzz=0 patching file Source/WTF/wtf/Platform.h Hunk #1 FAILED at 110. 1 out of 1 hunk FAILED -- saving rejects to file Source/WTF/wtf/Platform.h.rej error: Bad exit status from /var/tmp/rpm-tmp.Fc6k5b (%prep)
Looks like this is fixed in 2.3.4 properly already, the referenced code snippet in the patch already contains: /* CPU(PPC) - PowerPC 32-bit */ #if defined(__ppc__) \ || defined(__PPC__) \ || defined(__powerpc__) \ || defined(__powerpc) \ || defined(__POWERPC__) \ || defined(_M_PPC) \ || defined(__PPC) #define WTF_CPU_PPC 1 #ifndef __LITTLE_ENDIAN__ #define WTF_CPU_BIG_ENDIAN 1 #endif #endif
Oh, and, * Mon Mar 23 2015 Rex Dieter <rdieter> 2.3.4-5 - drop ppc64le patch (that no longer applies or is needed) Looks like I'd just forgotten to close this then (sorry).