Bug 1096346 - [Rubygem-Staypuft]: While setting up a new deployment there's no way to Unassign hosts from host-groups.
Summary: [Rubygem-Staypuft]: While setting up a new deployment there's no way to Unass...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: rubygem-staypuft
Version: 4.0
Hardware: x86_64
OS: Linux
medium
high
Target Milestone: z4
: 4.0
Assignee: Martyn Taylor
QA Contact: Omri Hochman
URL:
Whiteboard:
Depends On:
Blocks: 1093126
TreeView+ depends on / blocked
 
Reported: 2014-05-09 17:39 UTC by Omri Hochman
Modified: 2014-07-29 19:22 UTC (History)
5 users (show)

Fixed In Version: ruby193-rubygem-staypuft-0.0.13
Doc Type: Bug Fix
Doc Text:
Previously the deploy page button to add/remove hosts to a service was labelled 'Assign'. Consequently, this implied that this button was exclusively used for assigning hosts, whereas it was actually also used for unassigning. This fix renames the button to 'Assign / Unassign', with the result that it now more accurately reflects the expected behavior.
Clone Of:
Environment:
Last Closed: 2014-07-15 16:59:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Omri Hochman 2014-05-09 17:39:11 UTC
[Rubygem-Staypuft]: While setting up a new deployment there's no way to Unassign hosts from host-groups. 
 

Environment  (puddle : OpenStack/Foreman/2014-05-06.6/) 
-------------------------------------------------------
ruby193-rubygem-staypuft-0.0.12-1.el6ost.noarch
foreman-installer-staypuft-0.0.10-1.el6ost.noarch
openstack-puppet-modules-2013.2-9.1.el6ost.noarch
puppet-server-3.3.2-2.el6.noarch
puppet-3.3.2-2.el6.noarch
foreman-1.5.0.22-1.el6sat.noarch


Description:
------------
While created a new deployment I accidentally hit on the 'Assign' button and  associated host with a wrong hosts-group. When I wanted to undo this move 
there was no way to do it.  I was expecting something like Unassign button or that double clicking the host groups will revert the host back to be available.
Then I've tried to click on the host and 'edit' it -
(1) I tried to click the cancel-build .
(2) I tried to change it's host-group back to blank. 

None of the above reverted the host to be available again for re-assign in the deployment wizard page.

Comment 2 Martyn Taylor 2014-05-15 10:39:06 UTC
The way to do this is to unselect the check box of the host you incorrectly assigned then click assign again.

Could you please try this method and confirm if this works for you.

I will rename the button to some more descriptive of the behaviour.  Likely "Update Associations" or "Assign/Unassign".

Cheers

Comment 3 Martyn Taylor 2014-05-15 10:59:21 UTC
I went with "Assign / Unassign"

https://github.com/theforeman/staypuft/pull/125

Comment 4 Martyn Taylor 2014-05-15 12:50:09 UTC
commit adde32d9f29df03bd6525da27d3ae5063b4cb192
Author: Martyn Taylor <mtaylor>
Date:   Thu May 15 11:53:34 2014 +0100

    Renamed 'Assign' button to 'Assign / Unassign'
    
    The assign button on the deployment page actually removes hosts from a
    hostgroup as well as adding them.  This behaviour is not obvious since
    the button is named 'Assign' which suggests add only.  Renaming to make
    the behaviour more obvious.

Comment 5 Omri Hochman 2014-05-15 16:07:08 UTC
I checked again and it's possible to 'unassign' hosts by clicking again on the assign button - it allows only before 'deploy' (after deployment the check-box of the hosts is disabled) . 

notes : 
--------
(1) for this bug fix - we would like to switch the 'Assign' button to 'Unassign' -> after the host has been associated with host group.
(2) there is a GUI tweak that moves the focus from the selected host group to the first host group in the host-group list.  see :  #1098213
(3) For future release user should be able to Unassign hosts even after 'Deploy' 
see: #1098284

Comment 8 Omri Hochman 2014-05-27 21:43:58 UTC
Verified ruby193-rubygem-staypuft-0.0.16-1.el6ost.noarch.

I verified that it's possible to edit the host and change it's host-group to blank and then reassign the host to another role on the deployment.

Still need to check if the host should remain marked as "managed" or not in this case.


Note You need to log in before you can comment on or make changes to this bug.