Trying to build xfstests on a rawhide VM, and am getting this error: loggen.c:29:25: fatal error: xfs/xfs_log.h: No such file or directory #include <xfs/xfs_log.h> ...xfs/xfs_log.h was in xfsprogs-qa-devel in fedora 20, but seems to be missing in rawhide.
Looks like this was intentional: commit cc085d770adb821e1072fa2e403e62505de47799 Author: Dave Chinner <dchinner> Date: Wed Sep 4 22:05:20 2013 +0000 xfs: separate out log format definitions The on-disk format definitions for the log are spread randoms through a couple of header files. Consolidate it all in a single file that can be shared easily with userspace. This means that xfs_log.h and xfs_log_priv.h no longer need to be shared with userspace. Signed-off-by: Dave Chinner <dchinner> Review-by: Mark Tinguely <tinguely> Signed-off-by: Rich Johnston <rjohnston> ...but I guess xfstests hasn't caught up yet?
Ok, tried to fiddle with the headers, but then hit this bug: loggen.c: In function 'loggen_empty': loggen.c:226:27: error: 'XFS_TRANS_MAGIC' undeclared (first use in this function) trans->th_magic = XFS_TRANS_MAGIC; ^ ...and I don't see that symbol anywhere in the headers under /usr/include/xfs.
Created attachment 894668 [details] patch -- fix loggen.c compile This xfstests patch fixes it for me, and it still seems to work on f20 as well. Not sure if it's the right fix, but I'll send it upstream today sometime and gather comments. I think we can probably close this as NOTABUG since the real fix should probably be in xfstests.
Yeah, sounds like xfstests needs the fix. Thanks for sending it upstream! -Eric