Spec URL: https://raw.githubusercontent.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_mixer.spec SRPM URL: https://github.com/maci0/rpmbuild/raw/master/SRPMS/mingw-SDL2_mixer-2.0.0-1.fc20.src.rpm Description: MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library Fedora Account System Username: maci
Update: * Tue May 13 2014 Marcel Wysocki <maci> - 2.0.0-2 - Removed redundant BuildRequires Spec URL: https://raw.githubusercontent.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_mixer.spec SRPM URL: https://github.com/maci0/rpmbuild/raw/master/SRPMS/mingw-SDL2_mixer-2.0.0-2.fc20.src.rpm
Fixed Links: Spec URL: https://rawgit.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_mixer.spec SRPM URL: https://rawgit.com/maci0/rpmbuild/master/SRPMS/mingw-SDL2_mixer-2.0.0-2.fc20.src.rpm
Generally, it looks pretty good, just the homepage location needs fixing. * the homepage (URL and Source0) has a typo, it should be: http://www.libsdl.org/projects/SDL_mixer/ Would you be able to do a review swap with bug 1076456? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Header files in -devel subpackage, if present. Note: mingw32-SDL2_mixer : /usr/i686-w64-mingw32/sys- root/mingw/include/SDL2/SDL_mixer.h mingw64-SDL2_mixer : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL2/SDL_mixer.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages Not a problem for mingw packages. - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: mingw32-SDL2_mixer, mingw64-SDL2_mixer. Illegal package name: mingw32-SDL2_mixer, mingw64-SDL2_mixer. Does not provide -static: mingw32-SDL2_mixer, mingw64-SDL2_mixer. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries Also not a problem for mingw packages. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated", "LGPL (v2 or later) (with incorrect FSF address)", "ISC", "zlib/libpng", "GPL (v2 or later) (with incorrect FSF address)", "BSD (3 clause)", "LGPL (with incorrect FSF address)", "LGPL (v2.1 or later)", "*No copyright* Public domain". 313 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/1096809-mingw-SDL2_mixer/licensecheck.txt All the licenses other than zlib are in third-party libraries, which are not built, so the license tag is fine. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/x86_64-w64-mingw32/sys- root/mingw/include/SDL2(mingw64-SDL2), /usr/i686-w64-mingw32/sys- root/mingw/include/SDL2(mingw32-SDL2) As the binary packages generated from this package require SDL2, not owning those directories is fine. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://www.libSDL2.org/projects/SDL_mixer/release/SDL2_mixer-2.0.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags Incorrect homepage location, already mentioned above. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-SDL2_mixer , mingw64-SDL2_mixer [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. Note: mingw32-SDL2_mixer : /usr/i686-w64-mingw32/sys- root/mingw/lib/pkgconfig/SDL2_mixer.pc mingw64-SDL2_mixer : /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/SDL2_mixer.pc [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-SDL2_mixer-2.0.0-2.fc21.noarch.rpm mingw64-SDL2_mixer-2.0.0-2.fc21.noarch.rpm mingw-SDL2_mixer-2.0.0-2.fc21.src.rpm mingw32-SDL2_mixer.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti mingw32-SDL2_mixer.noarch: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw32-SDL2_mixer.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/COPYING.txt mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/README.txt mingw32-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/SDL2/SDL_mixer.h mingw32-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw32-SDL2_mixer.noarch: W: spurious-executable-perm /usr/i686-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw32-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/SDL2_mixer.pc mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/CHANGES.txt mingw32-SDL2_mixer.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-SDL2_mixer.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti mingw64-SDL2_mixer.noarch: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw64-SDL2_mixer.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw64-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL2/SDL_mixer.h mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/CHANGES.txt mingw64-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw64-SDL2_mixer.noarch: W: spurious-executable-perm /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw64-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/SDL2_mixer.pc mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/COPYING.txt mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/README.txt mingw64-SDL2_mixer.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw-SDL2_mixer.src: W: spelling-error %description -l en_US multi -> mulch, mufti mingw-SDL2_mixer.src: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw-SDL2_mixer.src: W: invalid-url Source0: http://www.libSDL2.org/projects/SDL_mixer/release/SDL2_mixer-2.0.0.tar.gz <urlopen error [Errno 111] Connection refused> 3 packages and 0 specfiles checked; 2 errors, 23 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mingw32-SDL2_mixer mingw64-SDL2_mixer mingw32-SDL2_mixer.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti mingw32-SDL2_mixer.noarch: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/COPYING.txt mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/README.txt mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/CHANGES.txt mingw64-SDL2_mixer.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti mingw64-SDL2_mixer.noarch: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/CHANGES.txt mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/COPYING.txt mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/README.txt 2 packages and 0 specfiles checked; 0 errors, 10 warnings. # echo 'rpmlint-done:' Requires -------- mingw32-SDL2_mixer (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libflac-8.dll) mingw32(libvorbisfile-3.dll) mingw32(msvcrt.dll) mingw32(sdl2.dll) mingw32(winmm.dll) mingw32-crt mingw32-filesystem mingw32-pkg-config mingw64-SDL2_mixer (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libflac-8.dll) mingw64(libvorbisfile-3.dll) mingw64(msvcrt.dll) mingw64(sdl2.dll) mingw64(winmm.dll) mingw64-crt mingw64-filesystem mingw64-pkg-config Provides -------- mingw32-SDL2_mixer: mingw32(sdl2_mixer.dll) mingw32-SDL2_mixer mingw64-SDL2_mixer: mingw64(sdl2_mixer.dll) mingw64-SDL2_mixer Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1096809 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Update: * Mon Jul 21 2014 maci <maci> - 2.0.0-3 - Fix homepage URL Spec URL: https://rawgit.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_mixer.spec SRPM URL: https://rawgit.com/maci0/rpmbuild/master/SRPMS/mingw-SDL2_mixer-2.0.0-2.fc20.src.rpm
The updated spec seems fine to me. The SRPM has not been updated, however (it is still the -2), but that seems like a typo, as using a -3 in the URL instead works fine.
yeah, sorry was a typo.
New Package SCM Request ======================= Package Name: mingw-SDL2_mixer Short Description: MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library Upstream URL: http://www.libSDL.org/projects/SDL_mixer/ Owners: maci epienbrock Branches: f19 f20 f21 el6 epel7 InitialCC: fedora-mingw.org
WARNING: "epienbrock" is not a valid FAS account. WARNING: "fedora-mingw.org" is not a valid FAS account.
New Package SCM Request ======================= Package Name: mingw-SDL2_mixer Short Description: MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library Upstream URL: http://www.libSDL.org/projects/SDL_mixer/ Owners: maci epienbro Branches: f19 f20 f21 epel7 InitialCC:
Git done (by process-git-requests).
mingw-SDL2_mixer-2.0.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mingw-SDL2_mixer-2.0.0-3.fc20
mingw-SDL2_mixer-2.0.0-3.fc20 has been pushed to the Fedora 20 testing repository.
mingw-SDL2_mixer-2.0.0-3.fc20 has been pushed to the Fedora 20 stable repository.