Bug 1096837 - "Add" buttons of Data assignment editor do not support i18n
Summary: "Add" buttons of Data assignment editor do not support i18n
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: jBPM Designer
Version: 6.0.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Jeremy Lindop
QA Contact: Kirill Gaevskii
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-12 14:00 UTC by Sona Mala
Modified: 2015-12-18 08:20 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-18 08:20:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screenshot: Assignment editor (18.39 KB, image/png)
2014-05-12 14:00 UTC, Sona Mala
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 979053 0 high CLOSED Update i18n of designer 2021-02-22 00:41:40 UTC

Internal Links: 979053

Description Sona Mala 2014-05-12 14:00:31 UTC
Created attachment 894716 [details]
Screenshot: Assignment editor

Description of problem:
Buttons which add a new data input/output assignment is not localized.

See https://github.com/droolsjbpm/jbpm-designer/blob/6.0.x/jbpm-designer-client/src/main/resources/org/jbpm/designer/public/js/Plugins/propertywindow.js:
   text: "[ New Data Input Assignment ]"
   text: "[ New Data Output Assignment ]"
   header: 'Assignment Type'

I think that there should be:
   text: ORYX.I18N.PropertyWindow.addInputAssignment
   text: ORYX.I18N.PropertyWindow.addOutputAssignment
   header: ORYX.I18N.PropertyWindow.assignType

Please do not forget use default value and add this property to all supported localization files (en, ja, de, es, ru).


Version-Release number of selected component (if applicable):
6.0.2 ER2 BPMS

Expected results:
These labels of buttons should be localized and it should depends on selected language.


Additional info:

Comment 1 Kirill Gaevskii 2015-12-07 18:16:21 UTC
Despite new I/O Editor was introduced this issue is still actual. But with little changes.

Properties without localization: 
text: "[ Input Assignment ]"
text: "[ Input Mapping ]"
text: "[ Output Mapping ]"

https://github.com/droolsjbpm/jbpm-designer/blob/6.3.x/jbpm-designer-client/src/main/resources/org/jbpm/designer/public/js/Plugins/propertywindow.js


But it seems like dead code because Mapping Editor is not in use any more. Am I right?

Comment 2 Jeremy Lindop 2015-12-08 09:52:34 UTC
(In reply to Kirill Gaevskii from comment #1)
> Despite new I/O Editor was introduced this issue is still actual. But with
> little changes.
> 
> Properties without localization: 
> text: "[ Input Assignment ]"
> text: "[ Input Mapping ]"
> text: "[ Output Mapping ]"
> 
> https://github.com/droolsjbpm/jbpm-designer/blob/6.3.x/jbpm-designer-client/
> src/main/resources/org/jbpm/designer/public/js/Plugins/propertywindow.js
> 
> 
> But it seems like dead code because Mapping Editor is not in use any more.
> Am I right?

The old Assignments Editor and DataInputs / DataOutputs editors aren't normaly used any more. There is a startup flag that can be used to trigger the use of these old dialogs instead of the new dataIOEditor. That's why the old code is still present.

Comment 3 Jeremy Lindop 2015-12-17 13:06:57 UTC
Kirill,
Even though this code can still be activated by using a startup flag, it doesn't make sense to do any more work on it. I'd suggest that we close the bug as "Won't Fix".

If you agree, will you close it. Thanks.

Comment 4 Kirill Gaevskii 2015-12-18 08:20:31 UTC
I am agree.


Note You need to log in before you can comment on or make changes to this bug.