Bug 1097195 - Hot plug CPU - allow over-commit
Summary: Hot plug CPU - allow over-commit
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.5.1
Assignee: Roy Golan
QA Contact: Pavel Stehlik
URL:
Whiteboard: sla
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-13 11:12 UTC by Roy Golan
Modified: 2016-02-10 19:42 UTC (History)
8 users (show)

Fixed In Version: ovirt-3.5.1_rc1
Clone Of:
Environment:
Last Closed: 2015-01-21 16:02:25 UTC
oVirt Team: SLA
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 31375 0 master MERGED core: Hot plug CPU - allow over-commit in QEMU limits Never
oVirt gerrit 34861 0 ovirt-engine-3.5 MERGED core: Hot plug CPU - allow over-commit in QEMU limits Never

Description Roy Golan 2014-05-13 11:12:27 UTC
Description of problem:

we need to allow over-commit the cpu number of a VM over a host. this is supported and doesn't pose a technical issue. 

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.Edit a running Vm
2. the numnber of sockets will not exceed the overall number of the host

Actual results:

the actual max numnber of CPU's should be the the vdc_config value, which is the qemu technical spec max 
http://doc.opensuse.org/products/draft/SLES/SLES-kvm_sd_draft/cha.kvm.limits.html

Expected results:
the limitations should be config based

Additional info:

Comment 1 Itamar Heim 2014-05-14 14:15:54 UTC
roy - why would we allow over-commit in hot-plug, when we wouldn't allow it when running the VM to begin with.
also, in such a bug its important to be accurate:
1. why sockets and not cores?
2. cores or hyperthreads based on cluster policy?

Comment 2 Michal Skrivanek 2014-05-19 09:04:11 UTC
we should allow it based on policy (the default one disallows, but that can be changed). We currently do not consult the scheduler at all.

indeed it's about vCPUs rather than socket/core/thread. Those should only comply with the maximum topology limits(16/16/?)

Comment 3 Michal Skrivanek 2014-07-14 12:12:02 UTC
seems we're out of time on 3.4.z really, so let's try to finish this up at least for 3.5

Comment 4 Sandro Bonazzola 2014-10-17 12:14:15 UTC
Moving pending bugs not fixed in 3.5.0 to 3.5.1.

Comment 5 Sandro Bonazzola 2015-01-15 14:14:43 UTC
This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA

Comment 6 Sandro Bonazzola 2015-01-21 16:02:25 UTC
oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.