Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1097195

Summary:	Hot plug CPU - allow over-commit
Product:	[Retired] oVirt	Reporter:	Roy Golan <rgolan>
Component:	ovirt-engine-core	Assignee:	Roy Golan <rgolan>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.5	CC:	bugs, gklein, iheim, michal.skrivanek, ofrenkel, rbalakri, rgolan, yeylon
Target Milestone:	---
Target Release:	3.5.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	sla
Fixed In Version:	ovirt-3.5.1_rc1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-01-21 16:02:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	SLA	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Roy Golan 2014-05-13 11:12:27 UTC

Description of problem:

we need to allow over-commit the cpu number of a VM over a host. this is supported and doesn't pose a technical issue. 

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.Edit a running Vm
2. the numnber of sockets will not exceed the overall number of the host

Actual results:

the actual max numnber of CPU's should be the the vdc_config value, which is the qemu technical spec max 
http://doc.opensuse.org/products/draft/SLES/SLES-kvm_sd_draft/cha.kvm.limits.html

Expected results:
the limitations should be config based

Additional info:

Comment 1 Itamar Heim 2014-05-14 14:15:54 UTC

roy - why would we allow over-commit in hot-plug, when we wouldn't allow it when running the VM to begin with.
also, in such a bug its important to be accurate:
1. why sockets and not cores?
2. cores or hyperthreads based on cluster policy?

Comment 2 Michal Skrivanek 2014-05-19 09:04:11 UTC

we should allow it based on policy (the default one disallows, but that can be changed). We currently do not consult the scheduler at all.

indeed it's about vCPUs rather than socket/core/thread. Those should only comply with the maximum topology limits(16/16/?)

Comment 3 Michal Skrivanek 2014-07-14 12:12:02 UTC

seems we're out of time on 3.4.z really, so let's try to finish this up at least for 3.5

Comment 4 Sandro Bonazzola 2014-10-17 12:14:15 UTC

Moving pending bugs not fixed in 3.5.0 to 3.5.1.

Comment 5 Sandro Bonazzola 2015-01-15 14:14:43 UTC

This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA

Comment 6 Sandro Bonazzola 2015-01-21 16:02:25 UTC

oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.