Bug 1097303 - Add virtio support for OpenBSD
Summary: Add virtio support for OpenBSD
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libosinfo
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zeeshan Ali
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-13 14:07 UTC by Jasper Lievisse Adriaanse
Modified: 2016-09-20 01:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-05 20:39:17 UTC
Embargoed:


Attachments (Terms of Use)
Fix typo for FreeBSD. (798 bytes, patch)
2014-05-13 14:07 UTC, Jasper Lievisse Adriaanse
no flags Details | Diff
OpenBSD supports virtio net/disk. (1.19 KB, patch)
2014-05-13 14:08 UTC, Jasper Lievisse Adriaanse
no flags Details | Diff
Fix typo for FreeBSD (850 bytes, patch)
2014-05-13 15:36 UTC, Christophe Fergeau
no flags Details | Diff
OpenBSD supports virtio net/disk. (850 bytes, patch)
2014-05-13 15:37 UTC, Christophe Fergeau
no flags Details | Diff

Description Jasper Lievisse Adriaanse 2014-05-13 14:07:33 UTC
Created attachment 895146 [details]
Fix typo for FreeBSD.

OpenBSD supports virtio net and disk since 5.3. As libosinfo has data on OpenBSD 5.4 and 5.4 we can add it there.

While here I fixed a typo in the FreeBSD file.

Comment 1 Jasper Lievisse Adriaanse 2014-05-13 14:08:22 UTC
Created attachment 895147 [details]
OpenBSD supports virtio net/disk.

Comment 2 Christophe Fergeau 2014-05-13 15:24:43 UTC
For what it's worth, it's better to send patches to the libosinfo mailing list rather than attaching them in bugzilla: http://libosinfo.org/communicate/

Regarding your second patch, you should only need to add the devices to freebsd 5.4 As they will be inherited by freebsd 5.5.

Comment 3 Christophe Fergeau 2014-05-13 15:26:02 UTC
(In reply to Christophe Fergeau from comment #2)
> For what it's worth, it's better to send patches to the libosinfo mailing
> list rather than attaching them in bugzilla:
> http://libosinfo.org/communicate/

Oh, and patches obtained through git format-patch would be easier to apply as I would not have to make up a commit message ;)

Comment 4 Christophe Fergeau 2014-05-13 15:36:13 UTC
Created attachment 895178 [details]
Fix typo for FreeBSD

Comment 5 Christophe Fergeau 2014-05-13 15:37:20 UTC
Created attachment 895179 [details]
OpenBSD supports virtio net/disk.

I'll push these 2 updated patches if the removed 'devices' don't cause issues.

Comment 6 Jasper Lievisse Adriaanse 2014-05-14 06:53:31 UTC
Excellent, thank you.

Comment 7 Christophe Fergeau 2014-06-05 20:39:17 UTC
This has been pushed to git now, thanks for the patches.


Note You need to log in before you can comment on or make changes to this bug.