Bug 1098080
| Summary: | [RFE] Use the count_bytes iflag in dd to simplify ddWatchCopy | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Federico Simoncelli <fsimonce> |
| Component: | RFEs | Assignee: | Ala Hino <ahino> |
| Status: | CLOSED WONTFIX | QA Contact: | Raz Tamir <ratamir> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | --- | CC: | amureini, asegundo, bazulay, bugs, lpeer, srevivo, tnisan, ylavi |
| Target Milestone: | --- | Keywords: | CodeChange, FutureFeature |
| Target Release: | --- | Flags: | ylavi:
ovirt-future?
rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack? |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-16 13:10:18 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1098078 | ||
| Bug Blocks: | |||
What is the impact of this RFE? what flow does it affect? ddWatchCopy has been removed from VDSM. |
Description of problem: Take advantage of the count_bytes iflag in dd in order to simplify ddWatchCopy (where we are currently maintaining our logic): def ddWatchCopy(src, dst, stop, size, offset=0): ... while left > 0: (iounit, count, iooffset) = _alignData(left, offset) ... cmd = [constants.EXT_DD, "if=%s" % src, "of=%s" % dst, "bs=%d" % iounit, "seek=%s" % iooffset, "skip=%s" % iooffset, "conv=%s" % conv, 'count=%s' % count] ... left = left % iounit offset = baseoffset + size - left