Bug 1098080 - [RFE] Use the count_bytes iflag in dd to simplify ddWatchCopy
Summary: [RFE] Use the count_bytes iflag in dd to simplify ddWatchCopy
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: vdsm
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: ---
Assignee: Ala Hino
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On: 1098078
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-15 09:17 UTC by Federico Simoncelli
Modified: 2019-04-28 13:43 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-11-16 13:10:18 UTC
oVirt Team: Storage
Embargoed:
ylavi: ovirt-future?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?


Attachments (Terms of Use)

Description Federico Simoncelli 2014-05-15 09:17:32 UTC
Description of problem:
Take advantage of the count_bytes iflag in dd in order to simplify ddWatchCopy (where we are currently maintaining our logic):

 def ddWatchCopy(src, dst, stop, size, offset=0):
     ...
     while left > 0:
         (iounit, count, iooffset) = _alignData(left, offset)
         ...
         cmd = [constants.EXT_DD, "if=%s" % src, "of=%s" % dst,
                "bs=%d" % iounit, "seek=%s" % iooffset, "skip=%s" % iooffset,
                "conv=%s" % conv, 'count=%s' % count]
         ...
         left = left % iounit
         offset = baseoffset + size - left

Comment 1 Yaniv Lavi 2016-12-05 12:55:03 UTC
What is the impact of this RFE? what flow does it affect?

Comment 2 Yaniv Kaul 2017-11-16 13:10:18 UTC
ddWatchCopy has been removed from VDSM.


Note You need to log in before you can comment on or make changes to this bug.