RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1098466 - adding invalid score for location constraints results in invalid CIB dump
Summary: adding invalid score for location constraints results in invalid CIB dump
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.0
Hardware: Unspecified
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Tomas Jelinek
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-16 09:41 UTC by Tomas Jelinek
Modified: 2015-03-05 09:19 UTC (History)
6 users (show)

Fixed In Version: pcs-0.9.126-1.el7
Doc Type: Bug Fix
Doc Text:
Cause: There is no score validation before putting the constraint with the score into CIB using cibadmin. Consequence: Cibmadmin rejects the CIB update with error message and invalid CIB dump. The error message nor the dump is not very helpful for the user to understand what is wrong. Fix: Validate the score before using it. Result: In case of invalid score entered the user is informed about the error by comprehensible error message.
Clone Of:
Environment:
Last Closed: 2015-03-05 09:19:25 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
proposed fix (3.47 KB, patch)
2014-05-16 13:43 UTC, Tomas Jelinek
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:0415 0 normal SHIPPED_LIVE pcs bug fix and enhancement update 2015-03-05 14:16:41 UTC

Description Tomas Jelinek 2014-05-16 09:41:52 UTC
Description of problem:
When user specifies invalid score in 'pcs constraint location' command the invalid CIB is dumped into terminal.

Version-Release number of selected component (if applicable):
pcs-0.9.115-32.el7

How reproducible:
always

Steps to Reproduce:
Run one of these commands:
pcs constraint location dummy1 prefers rh70-node1=foo
pcs constraint location dummy1 avoids rh70-node1=foo
pcs constraint location add locatest dummy1 rh70-node2 foo 

Actual results:
[root@localhost ~]# pcs constraint location dummy1 prefers rh70-node1=foo
Call cib_replace failed (-203): Update does not conform to the configured schema
{invalid CIB dumped here}

Expected results:
[root@localhost ~]# pcs constraint location dummy1 prefers rh70-node1=foo
Error: invalid score, use integer or INFINITY or -INFINITY

Comment 2 Tomas Jelinek 2014-05-16 13:43:05 UTC
Created attachment 896389 [details]
proposed fix

Comment 3 Tomas Jelinek 2014-09-11 08:57:58 UTC
Before Fix:
[root@rh70-node1 ~]# rpm -q pcs
pcs-0.9.115-32.el7.x86_64
[root@rh70-node1 ~]# pcs constraint location dummy prefers rh70-node1=foo
Call cib_replace failed (-203): Update does not conform to the configured schema
<cib admin_epoch="0" cib-last-written="Wed Sep 10 16:34:02 2014" crm_feature_set="3.0.7" epoch="6493" have-quorum="1" num_updates="1" update-client="cibadmin" update-origin="rh70-node1" validate-with="pacemaker-1.2" dc-uuid="1">
{output trimmed}

After Fix:
[root@rh70-node1 ~]# rpm -q pcs
pcs-0.9.126-1.el7.x86_64
[root@rh70-node1 ~]# pcs constraint location dummy prefers rh70-node1=foo
Error: invalid score 'foo', use integer or INFINITY or -INFINITY
[root@rh70-node1 ~]# echo $?
1

Comment 7 errata-xmlrpc 2015-03-05 09:19:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0415.html


Note You need to log in before you can comment on or make changes to this bug.