Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1098539

Summary: failed to create VM if no NUMA set is specified
Product: [Retired] oVirt Reporter: Francesco Romani <fromani>
Component: ovirt-engine-coreAssignee: Gilad Chaplik <gchaplik>
Status: CLOSED CURRENTRELEASE QA Contact: Artyom <alukiano>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 3.5CC: ahadas, chuan.liao, danken, dfediuck, fromani, gchaplik, gklein, iheim, mavital, msivak, rbalakri, sbonazzo, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: sla
Fixed In Version: ovirt-3.5.0-alpha1.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-17 12:33:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1069303    
Attachments:
Description Flags
libvirt log excerpt
none
VDSM log excerpt
none
engine logs corresponding to already attached libvirt and vdsm none

Description Francesco Romani 2014-05-16 14:00:54 UTC
Created attachment 896414 [details]
libvirt log excerpt

Description of problem:
On Fedora 19, the VM creation fails if no "nodeset" is given for NUMA parameters, with error

Thread-141::DEBUG::2014-05-16 15:30:51,105::vm::2405::vm.Vm::(setDownStatus) vmId=`9e33ca94-1cf7-4791-b063-c4709482f691`::Changed state to Down: invalid argument: Failed to parse bitmap '' (code=1)


Version-Release number of selected component (if applicable):
3.5.0-alpha1

How reproducible:
100%

Steps to Reproduce:
1. try create a VM using the default settings
2.
3.

Actual results:
VM cannot be created

Expected results:
VM is created


Additional info:
see the attachments for sample logs

Comment 1 Francesco Romani 2014-05-16 14:01:49 UTC
Created attachment 896415 [details]
VDSM log excerpt

Comment 2 Francesco Romani 2014-05-16 14:03:03 UTC
VDSM receives an empty nodeset from engine in the parameters of the vmCreate verb

'numaTune': {'nodeset': '', 'mode': 'preferred'}

and this ends up in the domain XML.
libvirt does not like it and abort the creation.

Comment 3 Sandro Bonazzola 2014-05-16 14:06:04 UTC
Created attachment 896416 [details]
engine logs corresponding to already attached libvirt and vdsm

Comment 4 Sandro Bonazzola 2014-05-16 14:07:53 UTC
Relevant packages:
 - vdsm-4.14.1-334.git20490b0.fc19.x86_64
 - ovirt-engine-3.5.0-0.0.master.20140515012237.git6924f01.fc19.noarch
 - libvirt-python-1.1.3.2-1.fc19.x86_64

oVirt 3.5.0 alpha 1 build.

Comment 5 Gilad Chaplik 2014-05-18 11:49:22 UTC
(In reply to Francesco Romani from comment #2)
> VDSM receives an empty nodeset from engine in the parameters of the vmCreate
> verb
> 
> 'numaTune': {'nodeset': '', 'mode': 'preferred'}
> 
> and this ends up in the domain XML.
> libvirt does not like it and abort the creation.

Do you open a bug for libvirt as well?

Comment 6 Francesco Romani 2014-05-19 06:15:25 UTC
(In reply to Gilad Chaplik from comment #5)
> (In reply to Francesco Romani from comment #2)
> > VDSM receives an empty nodeset from engine in the parameters of the vmCreate
> > verb
> > 
> > 'numaTune': {'nodeset': '', 'mode': 'preferred'}
> > 
> > and this ends up in the domain XML.
> > libvirt does not like it and abort the creation.
> 
> Do you open a bug for libvirt as well?

No, I didn't. The documentation of libvirt is not crystal clear to me, however it does not state an empty nodeset is supported, so the libvirt behaviour seems OK to me. Maybe I am missing something: what else could have done libvirt here?

Comment 7 Sandro Bonazzola 2014-05-20 08:21:27 UTC
I can see 2 patches not merged attached to this bug. Aren't those patches needed?

Comment 8 Gilad Chaplik 2014-05-20 12:03:00 UTC
(In reply to Sandro Bonazzola from comment #7)
> I can see 2 patches not merged attached to this bug. Aren't those patches
> needed?

removed. thanks!

Comment 9 Artyom 2014-07-31 11:33:06 UTC
Verified on vdsm-4.16.1-0.gita4d9abf.el6.x86_64
aslo in vdsm.log createVm ->'numaTune': {'mode': 'preferred'}

Comment 10 Sandro Bonazzola 2014-10-17 12:33:36 UTC
oVirt 3.5 has been released and should include the fix for this issue.