Bug 1098700 - Review Request: inkscape-table - Table support for inkscape
Summary: Review Request: inkscape-table - Table support for inkscape
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mukundan Ragavan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-17 12:09 UTC by Lubomir Rintel
Modified: 2014-07-26 07:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-26 07:28:07 UTC
Type: Bug
Embargoed:
nonamedotc: fedora-review+


Attachments (Terms of Use)

Description Lubomir Rintel 2014-05-17 12:09:22 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/inkscape-table.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/inkscape-table-1.0-1.fc21.src.rpm

Description:

This Inkscape extension provides support for drawing tables.

Comment 1 Mukundan Ragavan 2014-05-18 01:46:15 UTC
I use Inkscape almost everyday. :)

Taking for review.

Comment 2 Mukundan Ragavan 2014-05-18 21:59:27 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later)". Detailed output of licensecheck in
     /home/mukundan/personal/pkgs/reviews/1098700-inkscape-
     table/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

---> Please ask upstream to add the license text to the tarball.

[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: inkscape-table-1.0-1.fc21.noarch.rpm
          inkscape-table-1.0-1.fc21.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint inkscape-table
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'



Requires
--------
inkscape-table (rpmlib, GLIBC filtered):
    /usr/bin/env
    inkscape
    pygtk2
    python-lxml
    python2



Provides
--------
inkscape-table:
    inkscape-table



Source checksums
----------------
http://downloads.sourceforge.net/project/inkscape-tables/inkscape-table-1.0.tar.gz :
  CHECKSUM(SHA256) this package     : f17fe1c989c88e40131b3ebd1bd45d75049a807e6aace9fc0e714e012c194863
  CHECKSUM(SHA256) upstream package : f17fe1c989c88e40131b3ebd1bd45d75049a807e6aace9fc0e714e012c194863


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1098700
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

koji build for testing - http://koji.fedoraproject.org/koji/taskinfo?taskID=6861528


Package APPROVED!

Comment 3 Lubomir Rintel 2014-05-19 08:41:53 UTC
Thank you!

New Package SCM Request
=======================
Package Name: inkscape-table
Short Description: Table support for inkscape
Upstream URL: http://sourceforge.net/projects/inkscape-tables/
Owners: lkundrak
Branches: f19 f20 el6 epel7

Comment 4 Gwyn Ciesla 2014-05-19 12:19:32 UTC
Already complete.

Comment 5 Lubomir Rintel 2014-07-25 18:53:44 UTC
Hmm, does not look like it's complete:

[lkundrak@goatlord fedora]$ fedpkg clone inkscape-table
Cloning into 'inkscape-table'...
fatal: '/srv/git/rpms//inkscape-table.git' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Could not execute clone: Command '['git', 'clone', 'ssh://lkundrak.org/inkscape-table']' returned non-zero exit status 128
ERROR:rpkg:Could not execute clone: Command '['git', 'clone', 'ssh://lkundrak.org/inkscape-table']' returned non-zero exit status 128
[lkundrak@goatlord fedora]$

Comment 6 Gwyn Ciesla 2014-07-25 19:21:54 UTC
Hmm.  Not sure what went wrong, but it should be Ok now.

Comment 7 Lubomir Rintel 2014-07-26 07:28:07 UTC
Imported and built now.

Thank you!


Note You need to log in before you can comment on or make changes to this bug.