Created attachment 896781 [details]
patch

Description of problem:
When XML output is requested (usually due to machine parsing) the cli tool returns human readable output if the XML output isn't compiled in. The human readable output will not be parsed by XML parsers.

Version-Release number of selected component (if applicable):
3.5.0, 3.4.0 and possibly others

How reproducible:
100%

Steps to Reproduce:
1. have the CLI tool compiled with --disable-xml-output
2. try to run cli with XML output

Actual results:
$ ./gluster --xml volume info
XML output not supported. Ignoring '--xml' option
 
Volume Name: gv0
Type: Distribute
Volume ID: 1784c1e7-45ed-448e-815b-84c668971ce0
Status: Started
Number of Bricks: 1
Transport-type: tcp
Bricks:
Brick1: gluster-node-1:/mnt/gluster-brick
Options Reconfigured:
auth.allow: *
nfs.rpc-auth-allow: *
server.allow-insecure: on
$ echo $?
0

Expected results:
$ ./gluster --xml volume info
XML output not supported.
$ echo $?
1

Additional info:
See attached patch for suggested fix.