Spec URL: http://cycloptivity.fedorapeople.org/drupal7-addressfield/1.0-0.1/drupal7-addressfield.spec SRPM URL: http://cycloptivity.fedorapeople.org/drupal7-addressfield/1.0-0.1/drupal7-addressfield-1.0-0.1.beta5.fc19.src.rpm Description: Address Field defines a new field type to store international postal addresses, implementing a subset of the top-level address elements defined in the xNAL standard Fedora Account System Username: cycloptivity Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=6865719
Review: + Package builds successful in F21 x86_64 mock + rpmlint on generated rpms gave drupal7-addressfield.noarch: W: spelling-error Summary(en_US) intl -> int, lint, into drupal7-addressfield.noarch: W: spelling-error %description -l en_US xNAL -> anal drupal7-addressfield.src: W: spelling-error Summary(en_US) intl -> int, lint, into drupal7-addressfield.src: W: spelling-error %description -l en_US xNAL -> anal 2 packages and 0 specfiles checked; 0 errors, 4 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 37bfea1d918e84a5cfafde7124d667fdd16a0cd29b5dcaea9a84ce941fdb203e upstream tarball : 37bfea1d918e84a5cfafde7124d667fdd16a0cd29b5dcaea9a84ce941fdb203e + License is valid GPLv2+ and included in its own text file LICENSE.txt + Package follows drupal7 packaging guidelines Suggestions: 1) Group tag is not necessary in Fedora now and can be removed from spec file. See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag 2) change the Summary: Address Field defines a new field type to store intl addresses to Summary: Address Field defines a new field type to store international postal addresses and change the same in this review summary.
(In reply to Parag AN(पराग) from comment #1) > Suggestions: > 1) Group tag is not necessary in Fedora now and can be removed from spec > file. See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag Drupal 7 packaging guidelines template (https://fedoraproject.org/wiki/Packaging:Drupal7#Module) has the Group tag. Per overall packaging guidelines (https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag) it can stay to be compatible with EPEL and all Drupal pkgs are packaged for EPEL. Additional item: 3) "Requires: php(language) >= 5.1" not required and should not be present. You do need to run phpcompatinfo on the module though -- see https://fedoraproject.org/wiki/Packaging:Drupal7#PHP_Extensions
thanks Shawn for your suggestion. If this is going to be packaged for EPEL then group tag, buildroot can stay. Sam, Submit new updated package for final approval.
Spec URL: http://cycloptivity.fedorapeople.org/drupal7-addressfield/1.0-0.2/drupal7-addressfield.spec SRPM URL: http://cycloptivity.fedorapeople.org/drupal7-addressfield/1.0-0.2/drupal7-addressfield-1.0-0.2.beta5.fc19.src.rpm Description: Address Field defines a new field type to store international postal addresses Fedora Account System Username: cycloptivity Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=7081604 Thanks for the feedback guys. Updates are included.
Thanks. APPROVED
New Package SCM Request ======================= Package Name: drupal7-addressfield Short Description: Address Field defines a new field type to store international postal addresses Upstream URL: http://www.drupal.org/project/addressfield Owners: cycloptivity asrob siwinski Branches: f19 f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
drupal7-addressfield-1.0-0.2.beta5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/drupal7-addressfield-1.0-0.2.beta5.fc20
drupal7-addressfield-1.0-0.2.beta5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/drupal7-addressfield-1.0-0.2.beta5.fc19
drupal7-addressfield-1.0-0.2.beta5.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/drupal7-addressfield-1.0-0.2.beta5.el7
drupal7-addressfield-1.0-0.2.beta5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal7-addressfield-1.0-0.2.beta5.el6
I got the permission from this package submitter to build his packages. I see this package missed f21 branch please create it. Package Change Request ======================= Package Name: drupal7-addressfield New Branches: f21 Owners: cycloptivity asrob siwinski
drupal7-addressfield-1.0-0.2.beta5.el6 has been pushed to the Fedora EPEL 6 testing repository.
drupal7-addressfield-1.0-0.2.beta5.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/drupal7-addressfield-1.0-0.2.beta5.fc21
drupal7-addressfield-1.0-0.2.beta5.fc20 has been pushed to the Fedora 20 stable repository.
drupal7-addressfield-1.0-0.2.beta5.fc19 has been pushed to the Fedora 19 stable repository.
drupal7-addressfield-1.0-0.2.beta5.el6 has been pushed to the Fedora EPEL 6 stable repository.
drupal7-addressfield-1.0-0.2.beta5.el7 has been pushed to the Fedora EPEL 7 stable repository.
drupal7-addressfield-1.0-0.2.beta5.fc21 has been pushed to the Fedora 21 stable repository.