Bug 1099380 - The stroke5 table should not use “AUTO_SELECT = TRUE” but “AUTO_SELECT = FALSE”
Summary: The stroke5 table should not use “AUTO_SELECT = TRUE” but “AUTO_SELECT = FALSE”
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: ibus-table-chinese
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ding-Yi Chen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-20 07:36 UTC by Mike FABIAN
Modified: 2015-06-01 11:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-01 11:08:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Mike FABIAN 2014-05-20 07:36:45 UTC
The source for the stroke5 table contains

    AUTO_SELECT = TRUE

I don’t think this is useful for the stroke5 input method,
it should be set to FALSE.

When set to TRUE, AUTO_SELECT does the following 4 quite unrelated things:

    1) commit the matched phrase and a line feed instead of the tabkeys
       and no line feed when Return is typed (apparently Chinese input
       methods like Wubi want to insert the tabkeys instead of the phrase
       on Return, this is used as a quick way to insert one Latin word
       without having to switch to direct input mode or another input
       method. But for non-Chinese input methods like the Russian
       “translit”, this makes of course no sense).
    
    2) commit the matched phrase when Tab is typed
    
    3) When committing by typing Space, commit the phrase followed by a
       “ ” instead of only the phrase.
    
    4) if typing a valid input character has the result that there are no
       candidates anymore, but there were candidates before typing that
       character, pop that character from the input again, commit the
       first of the previous candidates and then reprocess the input
       character.  This is also mainly needed for non-Chinese input
       methods like the Russian “translit”. The “translit” table
       contains:
    
         sh ш
         shh щ
    
       so typing “sh” matches “ш” and “щ”. The
       candidate with the shortest key sequence comes
       first in the lookup table, therefore “sh ш”
       is shown in the preëdit (The other candidate,
       “shh щ” comes second in the lookup table and
       could be selected using arrow-down. But
       “translit” hides the lookup table by default).
    
       Now, when after typing “sh” one types “s”,
       the key “shs” has no match, so add_input('s')
       returns “False” and we end up here. We pop the
       last character “s” which caused the match to
       fail, commit first of the previous candidates,
       i.e. “sh ш” and feed the “s” into the
       key event handler again.

So AUTO_SELECT = TRUE seems to be not useful for Chinese input methods
like stroke5.

In the long run, I should probably improve ibus-table to split
the hard to understand “AUTO_SELECT” option into several separate,
more easy to understand options. Like a separate option whether to pass
the space to the application when committing with space.

Comment 1 Fedora Update System 2014-06-09 06:52:26 UTC
ibus-table-chinese-1.8.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ibus-table-chinese-1.8.1-1.fc20

Comment 2 Fedora Update System 2014-06-09 06:52:33 UTC
ibus-table-chinese-1.8.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ibus-table-chinese-1.8.1-1.fc19

Comment 3 Fedora Update System 2014-06-09 06:52:40 UTC
ibus-table-chinese-1.8.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/ibus-table-chinese-1.8.1-1.el6

Comment 4 Fedora Update System 2014-06-10 06:18:30 UTC
ibus-table-chinese-1.8.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ibus-table-chinese-1.8.2-1.fc20

Comment 5 Fedora Update System 2014-06-10 06:18:37 UTC
ibus-table-chinese-1.8.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ibus-table-chinese-1.8.2-1.fc19

Comment 6 Fedora Update System 2014-06-10 06:18:43 UTC
ibus-table-chinese-1.8.2-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/ibus-table-chinese-1.8.2-1.el6

Comment 7 Fedora Update System 2014-06-13 05:31:15 UTC
ibus-table-chinese-1.8.2-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2014-06-13 05:32:49 UTC
ibus-table-chinese-1.8.2-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora End Of Life 2015-05-29 11:54:12 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 10 Mike FABIAN 2015-06-01 11:08:15 UTC
It is fixed in ibus-table-chinese-1.8.2
ibus-table-chinese-stroke5-1.8.2


Note You need to log in before you can comment on or make changes to this bug.