Bug 1099649 - Permission Grant : Role-id Issue
Summary: Permission Grant : Role-id Issue
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Pulp
Classification: Retired
Component: API/integration
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Sayli Karmarkar
QA Contact: pulp-qe-list
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-20 20:12 UTC by Ben Stromski
Modified: 2015-03-23 01:12 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-02-28 22:06:45 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Pulp Redmine 433 0 None None None Never

Description Ben Stromski 2014-05-20 20:12:08 UTC
Description of problem:
A repository with a '.' in the repo-id will fail when trying to grant permission to a role-id to that repository.

Version-Release number of selected component (if applicable):
pulp 2.3.1-1.el6.noarch

How reproducible:
Everytime

Steps to Reproduce:
1. create a repo with a '.' in the name (i.e. rhel6.3-production)
2. create a new user & role (i.e. test/test)
3. pulp-admin auth permission grant --resource="/v2/repositories/rhel6.3-production/" -o execute -o update -o read -o delete --role-id="test"

Actual results:
An internal error occurred on the Pulp server. More information can be found in
the client log file ~/.pulp/admin.log.

-- From log --
  "exception": [
    "InvalidDocument: key '/v2/repositories/rhel6.2-qa-staging/' must not contain '.'\n"
  ],

Expected results:
This works when a --login=test is specified, but fails when --role-id is specified.

Additional info:

Comment 1 Sayli Karmarkar 2014-05-21 01:57:56 UTC
I was able to reproduce this problem. Looking at the code, it looks like we are storing permissions for roles in the Roles collection as opposed to in the permissions collection. They are stored with resource as the key and tuple of allowed operations as the value. Since keys in mongo cannot have "." in them, we are seeing the error. We should do what we do for Users which is saving permissions for them in the permissions collection.

Comment 2 amacdona@redhat.com 2014-11-17 20:22:18 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=1099649

Comment 3 Sayli Karmarkar 2015-01-12 22:16:53 UTC
Reviewed and merged https://github.com/pulp/pulp/pull/1394 submitted by a community member. Moving to modified

Comment 4 Brian Bouterse 2015-02-28 22:06:45 UTC
Moved to https://pulp.plan.io/issues/433


Note You need to log in before you can comment on or make changes to this bug.