Bug 1099674 - [abrt] mirrormanager-client: report_mirror:263:main:NameError: global name 'ProtocolError' is not defined
Summary: [abrt] mirrormanager-client: report_mirror:263:main:NameError: global name 'P...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: mirrormanager
Version: 20
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matt Domsch
QA Contact: Fedora Extras Quality Assurance
URL: https://retrace.fedoraproject.org/faf...
Whiteboard: abrt_hash:bdbd285213b106b49a6cb4ec416...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-20 23:58 UTC by Michael Hampton
Modified: 2015-06-30 01:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-30 01:28:49 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (17.06 KB, text/plain)
2014-05-20 23:58 UTC, Michael Hampton
no flags Details
File: environ (195 bytes, text/plain)
2014-05-20 23:58 UTC, Michael Hampton
no flags Details

Description Michael Hampton 2014-05-20 23:58:42 UTC
Version-Release number of selected component:
mirrormanager-client-1.3.7-7.fc20

Additional info:
reporter:       libreport-2.2.2
cmdline:        /usr/bin/python /usr/bin/report_mirror
executable:     /usr/bin/report_mirror
kernel:         3.14.4-200.fc20.x86_64
runlevel:       N 5
type:           Python
uid:            1001

Truncated backtrace:
#1 main in /usr/bin/report_mirror:263
#2 <module> in /usr/bin/report_mirror:272

Comment 1 Michael Hampton 2014-05-20 23:58:49 UTC
Created attachment 897763 [details]
File: backtrace

Comment 2 Michael Hampton 2014-05-20 23:58:59 UTC
Created attachment 897764 [details]
File: environ

Comment 3 Matt Domsch 2014-05-21 23:12:24 UTC
Please try with this simple patch:

commit 3e380285d339ae820d52a0679d7b0fa2f232d4dd
Author: Matt Domsch <matt>
Date:   Wed May 21 18:10:17 2014 -0500

    report-mirror: qualify xmlrpclib.ProtocolError
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1099674
    reported that ProtocolError isn't a handled exception.  It needs to be
    xmlrpclib.ProtocolError.

diff --git a/client/report_mirror b/client/report_mirror
index 00813be..fe64a93 100755
--- a/client/report_mirror
+++ b/client/report_mirror
@@ -290,7 +290,7 @@ def main():
                 print server.checkin(data)
             except socket.error, m:
                 print "Error checking in: %s.  Please try again later." % (m[1])
-            except ProtocolError:
+            except xmlrpclib.ProtocolError:
                 print "Error checking in: Service Temporarily Unavailable.  Please try again later."
                 sys.exit(1)                
             except xmlrpclib.Fault:

Comment 4 Michael Hampton 2014-05-22 14:27:16 UTC
So far so good with that patch. Though I'm not entirely sure how to reproduce the conditions that led to the error in the first place.

Comment 5 Fedora End Of Life 2015-05-29 11:54:41 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Fedora End Of Life 2015-06-30 01:28:49 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.