Bug 1099690 - unnecessary code in gf_history_changelog_done()
Summary: unnecessary code in gf_history_changelog_done()
Keywords:
Status: CLOSED EOL
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: 3.5.3
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Lalatendu Mohanty
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-21 02:02 UTC by Keith Schincke
Modified: 2016-06-17 16:23 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-06-17 16:23:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)
ret code update patch (472 bytes, patch)
2014-05-21 02:02 UTC, Keith Schincke
no flags Details | Diff

Description Keith Schincke 2014-05-21 02:02:47 UTC
Created attachment 897785 [details]
ret code update patch

Description of problem:
In gf-history-changelog:gf_history_changelog_done(), the function return value is updateded unnecessarily. ret is -1 at the start of the function. It is updated by a call to rename on line 76. On success, this value is set to 0. This is repeated on line 84. 

https://github.com/gluster/glusterfs/blame/master/xlators/features/changelog/lib/src/gf-history-changelog.c#L84


Version-Release number of selected component (if applicable):
3.5

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
See attached patch

Additional info:

Comment 1 Niels de Vos 2016-06-17 16:23:41 UTC
This bug is getting closed because the 3.5 is marked End-Of-Life. There will be no further updates to this version. Please open a new bug against a version that still receives bugfixes if you are still facing this issue in a more current release.


Note You need to log in before you can comment on or make changes to this bug.