Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1099690

Summary: unnecessary code in gf_history_changelog_done()
Product: [Community] GlusterFS Reporter: Keith Schincke <kschinck>
Component: coreAssignee: Lalatendu Mohanty <lmohanty>
Status: CLOSED EOL QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.5.3CC: bugs, lmohanty, vshankar
Target Milestone: ---Keywords: EasyFix, Patch, Triaged
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-17 16:23:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
ret code update patch none

Description Keith Schincke 2014-05-21 02:02:47 UTC 
Created attachment 897785 [details]
ret code update patch

Description of problem:
In gf-history-changelog:gf_history_changelog_done(), the function return value is updateded unnecessarily. ret is -1 at the start of the function. It is updated by a call to rename on line 76. On success, this value is set to 0. This is repeated on line 84. 

https://github.com/gluster/glusterfs/blame/master/xlators/features/changelog/lib/src/gf-history-changelog.c#L84


Version-Release number of selected component (if applicable):
3.5

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
See attached patch

Additional info:
Comment 1 Niels de Vos 2016-06-17 16:23:41 UTC 
This bug is getting closed because the 3.5 is marked End-Of-Life. There will be no further updates to this version. Please open a new bug against a version that still receives bugfixes if you are still facing this issue in a more current release.