Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1099858

Summary:	tests/encryption/crypt.t is failing because posix_open allows open on symlinks
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	posix	Assignee:	Vijay Bellur <vbellur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 08:32:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pranith Kumar K 2014-05-21 11:19:26 UTC

Description of problem:
If you run tests/encryption/crypt.t it hangs. Because posix_open performs open on softlink.

Version-Release number of selected component (if applicable):


How reproducible:
Once in a while.

Steps to Reproduce:
1.run prove -rfv tests/encryption/crypt.t
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-05-21 11:25:41 UTC

REVIEW: http://review.gluster.org/7823 (storage/posix: Don't allow open on symlink) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-05-21 11:56:23 UTC

REVIEW: http://review.gluster.org/7824 (encryption/crypt: Don't perform open on symlinks) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Anand Avati 2014-05-22 12:26:01 UTC

REVIEW: http://review.gluster.org/7824 (encryption/crypt: Don't perform open on symlinks) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 4 Anand Avati 2014-05-22 12:30:27 UTC

REVIEW: http://review.gluster.org/7823 (storage/posix: Don't allow open on symlink) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 5 Anand Avati 2014-05-23 06:31:58 UTC

COMMIT: http://review.gluster.org/7823 committed in master by Vijay Bellur (vbellur) 
------
commit 0127da7bb24794e737adc5a3195d3c54a175257f
Author: Pranith Kumar K <pkarampu>
Date:   Wed May 21 15:17:23 2014 +0530

    storage/posix: Don't allow open on symlink
    
    Change-Id: Ie38ecad621d5cb351c607c9676814c573834cb0b
    BUG: 1099858
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/7823
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 Anand Avati 2014-05-23 10:11:17 UTC

COMMIT: http://review.gluster.org/7824 committed in master by Vijay Bellur (vbellur) 
------
commit f0ccf3ac43cd6e0fe1b3dc1a429cb3ec18a25db7
Author: Pranith Kumar K <pkarampu>
Date:   Wed May 21 17:15:34 2014 +0530

    encryption/crypt: Don't perform open on symlinks
    
    Change-Id: I9be8634f8f3b09def21ba977050330aa3f26c230
    BUG: 1099858
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/7824
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 7 Niels de Vos 2014-09-22 12:40:42 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 8 Niels de Vos 2014-11-11 08:32:51 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users