Bug 1100144 - provide a way to minimize effects of mempool while debugging memory leaks/corruptions
Summary: provide a way to minimize effects of mempool while debugging memory leaks/cor...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-22 06:15 UTC by Pranith Kumar K
Modified: 2014-11-11 08:33 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Clone Of:
Environment:
Last Closed: 2014-11-11 08:33:01 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2014-05-22 06:15:55 UTC
Description of problem:

    Problems:
     - Mempool comes in the way of debugging mem-leaks/corruptions
       because tools like valgrind can't detect mem-pools.
    
     - Accessing freed pointers may crash only when the mem-pool
       is completely exhausted.
    
    Solution:
    In DEBUG builds set mempool count to 1 irrespective of the
    pool size requested. This should help in debugging
    memory-leaks/corruptions.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-05-22 06:17:34 UTC
REVIEW: http://review.gluster.org/7835 (libglusterfs: Provide a way to minimize mempool effects.) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-05-22 10:22:55 UTC
REVIEW: http://review.gluster.org/7835 (libglusterfs: Provide a way to minimize mempool effects.) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Anand Avati 2014-05-22 11:55:24 UTC
REVIEW: http://review.gluster.org/7835 (libglusterfs: Provide a way to disable mempool effects.) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 4 Anand Avati 2014-05-22 12:35:52 UTC
REVIEW: http://review.gluster.org/7835 (libglusterfs: Provide a way to disable mempool effects) posted (#6) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 5 Anand Avati 2014-05-23 06:48:09 UTC
COMMIT: http://review.gluster.org/7835 committed in master by Vijay Bellur (vbellur) 
------
commit 9ce93bc3be1dd5a5caecbb45966bc6b7b8e2c32b
Author: Pranith Kumar K <pkarampu>
Date:   Wed May 21 22:37:13 2014 +0530

    libglusterfs: Provide a way to disable mempool effects
    
    Problems:
     - Mempool comes in the way of debugging mem-leaks/corruptions
       because tools like valgrind can't detect mem-pools.
    
     - Accessing freed pointers may crash only when the mem-pool
       is completely exhausted.
    
    Solution:
    In DEBUG builds set mempool count to 0 irrespective of the
    pool size requested. This should help in debugging
    memory-leaks/corruptions.
    
    Change-Id: I7c6a2d696e330f12acff57ebdc589cc150e9ab79
    BUG: 1100144
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/7835
    Reviewed-by: Xavier Hernandez <xhernandez>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 Anand Avati 2014-05-23 07:38:58 UTC
REVIEW: http://review.gluster.org/7858 (libglusterfs: Fix unused variable warning) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 7 Anand Avati 2014-05-24 14:36:06 UTC
REVIEW: http://review.gluster.org/7858 (libglusterfs: Fix unused variable warning) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 8 Anand Avati 2014-05-24 16:51:59 UTC
COMMIT: http://review.gluster.org/7858 committed in master by Vijay Bellur (vbellur) 
------
commit b7ae88b63fb6ea1abdb86669f2a786b94a6470b4
Author: Pranith Kumar K <pkarampu>
Date:   Fri May 23 13:06:26 2014 +0530

    libglusterfs: Fix unused variable warning
    
    Change-Id: If385ba0993fdbd3e3b7500b2b6631721911e0ab3
    BUG: 1100144
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/7858
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 9 Anand Avati 2014-09-19 07:26:23 UTC
REVIEW: http://review.gluster.org/8774 (libglusterfs: Provide a way to disable mempool effects) posted (#1) for review on release-3.5 by Krutika Dhananjay (kdhananj)

Comment 10 Niels de Vos 2014-09-22 12:40:50 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 11 Niels de Vos 2014-11-11 08:33:01 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.