Bug 1100330 - Clarify the error message in migration 0009 when qpid dependencies are not satisfied
Summary: Clarify the error message in migration 0009 when qpid dependencies are not sa...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: async/tasks
Version: Master
Hardware: All
OS: Linux
medium
low
Target Milestone: ---
: 2.4.0
Assignee: Randy Barlow
QA Contact: Ina Panova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-22 14:51 UTC by Randy Barlow
Modified: 2014-08-09 06:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-09 06:54:19 UTC
Embargoed:


Attachments (Terms of Use)

Description Randy Barlow 2014-05-22 14:51:44 UTC
Our error messages in migration 0009_qpid_queues[0] aren't quite in agreement with the packages that our release notes say to install[1]. According to Brian, the release notes are correct, so we should adjust the error messages in the migration in accordance. It could be nice if the error messages also linked to these release notes, or if we added a section to the troubleshooting section of the docs about this that they could link to.

[0] https://github.com/pulp/pulp/blob/master/server/pulp/server/db/migrations/0009_qpid_queues.py#L46
[1] http://pulp-user-guide.readthedocs.org/en/latest/release-notes/2.4.x.html#upgrade-instructions-for-2-3-x-2-4-0

Comment 1 Brian Bouterse 2014-05-22 15:13:25 UTC
Technically, both are right, but the error message could be more useful.

The documentation recommends installing the packages via RPM; the python-qpid-qmf python-qpid give you the python packages qpid.messaging and qpidtoollibs. The user could read the error message and decide to pip install those python packages. The migration cares that those packages exist, not how the user installs them.

Mixing pip and rpm on an install is a bad idea, so, I think the best thing to do is to update the error message to recommend using yum to install the python-qpid-qmf and python-qpid packages.

Perhaps we should link to the docs in the error message. If we do, maybe we should put all the hard-coded doc links as doc constants somewhere in a new or existing module so we don't repeat ourselves, and keep it all in one place.

Comment 2 Randy Barlow 2014-05-30 21:35:16 UTC
https://github.com/pulp/pulp/pull/994

Comment 3 Jeff Ortel 2014-06-11 01:33:03 UTC
build: 2.4.0-0.20.beta

Comment 4 Ina Panova 2014-06-11 13:58:05 UTC
from /var/log/messages:
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:INFO: Applying pulp.server.db.migrations version 9
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.migrations.0009_qpid_queues:ERROR: Migration 0009 did not run because the python package qpidtoollibs is not installed. Please install 
qpidtoollibs and rerun the migrations. See http://pulp-user-guide.readthedocs.org/en/pulp-2.4/troubleshooting.html#qpidtoollibs-is-not-installed for more information.
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL: Applying migration pulp.server.db.migrations.0009_qpid_queues failed.
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL: Migration 0009 did not run because the python package qpidtoollibs is not installed. Please install qpidtoollibs and r
erun the migrations. See http://pulp-user-guide.readthedocs.org/en/pulp-2.4/troubleshooting.html#qpidtoollibs-is-not-installed for more information.
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL: Traceback (most recent call last):
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL:   File "/usr/lib/python2.7/site-packages/pulp/server/db/manage.py", line 86, in migrate_database
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL:     update_current_version=not options.test)
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL:   File "/usr/lib/python2.7/site-packages/pulp/server/db/migrate/models.py", line 161, in apply_migration
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL:     migration.migrate()
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL:   File "/usr/lib/python2.7/site-packages/pulp/server/db/migrations/0009_qpid_queues.py", line 56, in migrate
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL:     raise Exception(msg)
Jun 11 11:15:31 ec2-54-74-117-222 pulp: pulp.server.db.manage:CRITICAL: Exception: Migration 0009 did not run because the python package qpidtoollibs is not installed. Please install qpidtoo
llibs and rerun the migrations. See http://pulp-user-guide.readthedocs.org/en/pulp-2.4/troubleshooting.html#qpidtoollibs-is-not-installed for more information.

Moving to Verified.

Comment 5 Randy Barlow 2014-08-09 06:54:19 UTC
This has been fixed in Pulp 2.4.0-1.


Note You need to log in before you can comment on or make changes to this bug.