Bug 1100351 - [oo-admin] Usage of oo-admin-ctl-gears not display when run "oo-admin-ctl-gears"
Summary: [oo-admin] Usage of oo-admin-ctl-gears not display when run "oo-admin-ctl-gears"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Containers
Version: 2.1.0
Hardware: Unspecified
OS: Unspecified
high
low
Target Milestone: ---
: ---
Assignee: Brenton Leanhardt
QA Contact: libra bugs
URL:
Whiteboard:
Depends On: 1099754
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-22 15:44 UTC by Brenton Leanhardt
Modified: 2014-08-04 13:27 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
The following administrative commands on node hosts did not display helpful usage information when run without options: oo-admin-ctl-gears, oo-admin-gear, oo-admin-repair-node, oo auto-idler, oo-devel-node. The gear command on gears also had the same issue. This bug fix updates these commands to display their help page when run without options.
Clone Of: 1099754
Environment:
Last Closed: 2014-08-04 13:27:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:0999 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 2.1.4 bug fix and enhancement update 2014-08-04 17:26:43 UTC

Description Brenton Leanhardt 2014-05-22 15:44:53 UTC
+++ This bug was initially created as a clone of Bug #1099754 +++

Description of problem:
Just display "invalid command. Use --help for more information" when run "oo-admin-ctl-gears", shoud show usage as below
Usage: /usr/sbin/oo-admin-ctl-gears {startall|stopall|status|restartall|condrestartall|startgear|stopgear|restartgear|list}

Version-Release number of selected component (if applicable):
devenv_4800

How reproducible:
always

Steps to Reproduce:

1. login the instance and run the command "oo-admin-ctl-gears"

Actual results:
[root@ip-10-237-148-217 ~]# oo-admin-ctl-gears 
invalid command. Use --help for more information

[root@ip-10-237-148-217 ~]# oo-broker oo-admin-ctl-gears
2014/05/21 03:33:27 Unable to locate oo-admin-ctl-gears

Expected results:
The usage of "oo-admin-ctl-gears" should be displayed as below.
Usage: /usr/sbin/oo-admin-ctl-gears {startall|stopall|status|restartall|condrestartall|startgear|stopgear|restartgear|list}

Additional info:
N/A

--- Additional comment from Jhon Honce on 2014-05-22 11:39:37 EDT ---

Fixed in https://github.com/openshift/origin-server/pull/5438

Comment 1 Lili Nader 2014-06-06 00:06:59 UTC
Works for me on devenv.  You do not need oo-broker to run oo-admin-ctl-gears.

Comment 2 Luke Meyer 2014-06-06 15:00:06 UTC
It's fixed upstream; need to cherrypick it for OSE.

Comment 3 Brenton Leanhardt 2014-07-15 13:18:28 UTC
Upstream commit:

commit aed34b8c6096c23a417bc35f12e31080611928f5
Author: Jhon Honce <jhonce>
Date:   Thu May 22 08:13:42 2014 -0700

    Bug 1099754 - Set default_command to help
    
    * For scripts that use commander, set the default command to help

Comment 6 Gaoyun Pei 2014-07-16 05:58:26 UTC
Verify this bug on puddle 2.1.z/2014-07-15.1

Run "oo-admin-ctl-gears", "oo-admin-gear", "oo-admin-repair-node", "oo-auto-idler", "oo-devel-node" on node, help page would be shown.

Run "gear" in gears, help page would be shown.

Comment 8 errata-xmlrpc 2014-08-04 13:27:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0999.html


Note You need to log in before you can comment on or make changes to this bug.