Bug 1100740 - libraries.sh can't handle long library names (over 16 characters)
Summary: libraries.sh can't handle long library names (over 16 characters)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: beakerlib
Version: 19
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Dalibor Pospíšil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: Release
Depends On:
Blocks: Fedora-beakerlib-1.9-3 1116317
TreeView+ depends on / blocked
 
Reported: 2014-05-23 11:32 UTC by Alicja Kario
Modified: 2014-07-30 06:57 UTC (History)
4 users (show)

Fixed In Version: beakerlib-1.9-3.fc20
Clone Of:
Environment:
Last Closed: 2014-07-30 06:57:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Alicja Kario 2014-05-23 11:32:51 UTC
Description of problem:
When importing library with very long name (over 16 characters) the rlImport command returns "command not found" error

Version-Release number of selected component (if applicable):
beakerlib-1.8-1.fc19.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create library with long name
2. rlImport it
3. run the test

Actual results:
 /usr/share/beakerlib/libraries.sh: line 305: __INTERNAL_LIBRARY_LOCATIONS_C6f70656e73736c_L63657274696669636174652d67656e65: command not found
:: [ 18:25:53 ] :: [ ERROR   ] :: rlImport: Error processing: __INTERNAL_LIBRARY_LOCATIONS_C6f70656e73736c_L63657274696669636174652d67656e65
726174696f6e='/mnt/tests/CoreOS/openssl/Library/certificate-generation'
:: [   FAIL   ] :: Running 'rlImport openssl/certificate-generation' (Expected 0, got 1)

Expected results:
Library imported

Additional info:
problem caused by lines 268 and 269' use of `od`, if the value to be converted is longer than 16 characters, it will be outputted on two lines which then are not collapsed by following tr:

    local COMPONENT_hash=$( echo -n "$COMPONENT" | od -A n -t x1 -v | tr -d ' ' )
    local LIBRARY_hash=$( echo -n "$LIBRARY" | od -A n -t x1 -v | tr -d ' ' )

the code should look like this:

    local COMPONENT_hash=$( echo -n "$COMPONENT" | od -A n -t x1 -v | tr -d ' \n' )
    local LIBRARY_hash=$( echo -n "$LIBRARY" | od -A n -t x1 -v | tr -d ' \n' )

Comment 2 Fedora Update System 2014-06-17 13:42:16 UTC
beakerlib-1.9-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-1.fc20

Comment 3 Fedora Update System 2014-06-17 23:29:46 UTC
Package beakerlib-1.9-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing beakerlib-1.9-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7442/beakerlib-1.9-1.fc20
then log in and leave karma (feedback).

Comment 4 Alicja Kario 2014-06-18 10:35:19 UTC
Issue verified as fixed on F20:

:: [  BEGIN   ] :: Running 'rlImport openssl/certificate-generation'
:: [ 12:32:51 ] :: [ INFO    ] :: rlImport: Found 'openssl/certificate-generation' in /mnt/tests
:: [ 12:32:51 ] :: [ INFO    ] :: rlImport: Will try to import openssl/certificate-generation from /mnt/tests/CoreOS/openssl/Library/certificate-generation/lib.sh
:: [   PASS   ] :: Command 'rlImport openssl/certificate-generation' (Expected 0, got 0)

Comment 5 Fedora Update System 2014-07-02 08:01:58 UTC
beakerlib-1.9-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-2.fc20

Comment 6 Dalibor Pospíšil 2014-07-04 08:51:01 UTC
Please consider the package fixing this bug available in Fedora stable repos once bz1116308 is closed and RHEL stable repos once bz1116317 is closed.

Fixed in:
beakerlib-1.9-2.fc19
beakerlib-1.9-2.fc20
beakerlib-1.9-2.fc21
beakerlib-1.9-3.el5
beakerlib-1.9-2.el6
beakerlib-1.9-2.el7

Comment 7 Dalibor Pospíšil 2014-07-04 08:52:08 UTC
returning back verified status

Comment 8 Fedora Update System 2014-07-17 13:16:05 UTC
beakerlib-1.9-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-3.fc20

Comment 9 Fedora Update System 2014-07-30 06:57:39 UTC
beakerlib-1.9-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.