Spec URL: http://asrob.fedorapeople.org/SOURCES/drupal7-views_slideshow.spec SRPM URL: http://asrob.fedorapeople.org/SOURCES/drupal7-views_slideshow-3.1-1.fc21.src.rpm Description: Views Slideshow can be used to create a slideshow of any content (not just images) that can appear in a View. Powered by jQuery, it is heavily customizable: you may choose slideshow settings for each View you create. Fedora Account System Username: asrob koji url: https://koji.fedoraproject.org/koji/taskinfo?taskID=6882953 rpmlint output: rpmlint drupal7-views_slideshow.spec ~/Downloads/drupal7-views_slideshow-3.1-1.fc21.src.rpm drupal7-views_slideshow.src: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show drupal7-views_slideshow.src: W: spelling-error %description -l en_US slideshow -> sideshow, slide show, slide-show drupal7-views_slideshow.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry drupal7-views_slideshow.src: W: spelling-error %description -l en_US customizable -> customization 1 packages and 1 specfiles checked; 0 errors, 4 warnings.
This package looks pretty good, other than the Buildroot and %clean issues noted at th top of the "SHOULD items" section. Please correct those two items and I will approve this package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: drupal7-views_slideshow-3.1-1.fc21.noarch.rpm drupal7-views_slideshow-3.1-1.fc21.src.rpm drupal7-views_slideshow.noarch: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show drupal7-views_slideshow.noarch: W: spelling-error %description -l en_US slideshow -> sideshow, slide show, slide-show drupal7-views_slideshow.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry drupal7-views_slideshow.noarch: W: spelling-error %description -l en_US customizable -> customization drupal7-views_slideshow.src: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show drupal7-views_slideshow.src: W: spelling-error %description -l en_US slideshow -> sideshow, slide show, slide-show drupal7-views_slideshow.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry drupal7-views_slideshow.src: W: spelling-error %description -l en_US customizable -> customization 2 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint drupal7-views_slideshow drupal7-views_slideshow.noarch: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show drupal7-views_slideshow.noarch: W: spelling-error %description -l en_US slideshow -> sideshow, slide show, slide-show drupal7-views_slideshow.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry drupal7-views_slideshow.noarch: W: spelling-error %description -l en_US customizable -> customization 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- drupal7-views_slideshow (rpmlib, GLIBC filtered): drupal7(core) php-pcre php-xml Provides -------- drupal7-views_slideshow: drupal7(views_slideshow) drupal7(views_slideshow_cycle) drupal7-views_slideshow Source checksums ---------------- http://ftp.drupal.org/files/projects/views_slideshow-7.x-3.1.tar.gz : CHECKSUM(SHA256) this package : d61c359ac28e0b40087e8ede1a6b72276f784e31a61474a1e0c6ad7e89d7bb65 CHECKSUM(SHA256) upstream package : d61c359ac28e0b40087e8ede1a6b72276f784e31a61474a1e0c6ad7e89d7bb65 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1100873 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
I've re-created them. http://asrob.fedorapeople.org/SOURCES/drupal7-views_slideshow.spec http://asrob.fedorapeople.org/SOURCES/drupal7-views_slideshow-3.1-1.fc21.src.rpm
Approved.
New Package SCM Request ======================= Package Name: drupal7-views_slideshow Short Description: Views Slideshow can be used to create a slideshow of any content Upstream URL: https://drupal.org/project/views_slideshow Owners: asrob jsmith siwinski Branches: f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
drupal7-views_slideshow-3.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/drupal7-views_slideshow-3.1-1.fc20
drupal7-views_slideshow-3.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal7-views_slideshow-3.1-1.el6
drupal7-views_slideshow-3.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
drupal7-views_slideshow-3.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
drupal7-views_slideshow-3.1-1.fc20 has been pushed to the Fedora 20 stable repository.