RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
virsh vcpupin treats all --vcpu argument as signed, and it only check if
vcpu value is bigger than max vcpu.
But virDomainPinVcpu only accepts unsigned vcpu from argument.
So vcpupin to a negative value will get an inaccurate error "numerical overflow".

Version-Release number of selected component (if applicable):
libvirt-1.1.1-29.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. set an negative value to --vcpu

# virsh vcpupin r7 -1 0
error: numerical overflow: input too large: 4294967295

There is no reason to tell the user that he just inputed a large number '4294967295'.

Expect result:
# virsh vcpupin r7 -1 0
error: vcpupin: Invalid vCPU number.

Fixed upstream:

commit e43041048073d5ee95c22b9a313f52a18ecec0d8
Author: Jincheng Miao <jmiao>
Date:   Thu May 29 11:34:40 2014 +0800

    virsh: forbid negative vcpu argument to vcpupin
    
    The vcpupin command allowed specifying a negative number for the --vcpu
    argument. This would the overflow when the underlying virDomainPinVcpu
    API was called.
    
     $ virsh vcpupin r7 -1 0
     error: numerical overflow: input too large: 4294967295
    
    Switch the vCPU variable to a unsigned int and parse it using the
    corresponding function.
    
    Also improve the vcpupin test to cover all the defects.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1101059
    
    Signed-off-by: Jincheng Miao <jmiao>
    Signed-off-by: Peter Krempa <pkrempa>

Verify it as follows. The result is expected. Move its status to VERIFIED.


# rpm -q libvirt
libvirt-1.2.8-8.el7.x86_64

# virsh vcpupin r7 -1 0
error: vcpupin: Invalid vCPU number.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html