Bug 1101524
| Summary: | The download malformed cartridge is also added to the app even if the command "rhc cartridge add" failed | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Brenton Leanhardt <bleanhar> |
| Component: | Containers | Assignee: | Luke Meyer <lmeyer> |
| Status: | CLOSED ERRATA | QA Contact: | libra bugs <libra-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 2.1.0 | CC: | adellape, cryan, gusun, jokerman, libra-onpremise-devel, lmeyer, mmccomas, yanpzhan |
| Target Milestone: | --- | Keywords: | Regression, Upstream |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-openshift-origin-common-1.22.5.6-1.el6op | Doc Type: | Bug Fix |
| Doc Text: |
Deploying a downloadable cartridge that had a malformed manifest to an application reported an error, however the cartridge was still added to the application. As a result, the application could no longer be deleted using the client tools. This bug fix updates manifest validation when adding cartridges; adding a downloadable cartridge with a malformed manifest now provides better information on problematic entries and the cartridge is no longer added to the application.
|
Story Points: | --- |
| Clone Of: | 1100743 | Environment: | |
| Last Closed: | 2014-06-23 07:37:56 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1100743 | ||
| Bug Blocks: | |||
|
Description
Brenton Leanhardt
2014-05-27 12:02:04 UTC
Verified on 2.1.z/2014-06-10.3
Steps to verify:
1.Create an app
# rhc app create test1 php-5.3
2.add the download malformed cartridge to the app
# rhc cartridge add https://raw.githubusercontent.com/jhou1/openshift-malformed-cart/master/metadata/manifest.yml -a test1
3.Check the app
# rhc app show test1 -l zyp
4.Delete the app
# rhc app delete test1 -l
Actual results:
2.Prompt info:
The cartridge
'https://raw.githubusercontent.com/jhou1/openshift-malformed-cart/master/metadata/manifest.yml'
will be downloaded and installed
Adding
https://raw.githubusercontent.com/jhou1/openshift-malformed-cart/master/metadata/manifest.yml
to application 'test1' ...
Unable to complete the requested operation due to: Couldn't parse endpoints:
Couldn't parse endpoint entry '{"Private-IP-Name"=>"DB_HOST",
"Private-Port"=>3306, "Public-Port-Name"=>"DB_PROXY_PORT"}': Private-Port-Name
is a required element
Reference ID: 8064ca3c17700ce49bb358ad3ce402d8
3.The app info showed without the malformed cartridge added
test1 @ http://test1-yes.ose21z-manual.com.cn/
(uuid: 5397f1a8db26c85e6f000038)
----------------------------------------------
Domain: yes
Created: 11:05 PM
Gears: 1 (defaults to small)
Git URL: ssh://5397f1a8db26c85e6f000038.com.cn/~/git/test1.git/
SSH: 5397f1a8db26c85e6f000038.com.cn
Deployment: auto (on git push)
php-5.3 (PHP 5.3)
-----------------
Gears: 1 small
4.Could delete successfully:
This is a non-reversible action! Your application code and data will be
permanently deleted if you continue!
Are you sure you want to delete the application 'test1'? (yes|no): yes
Deleting application 'test1' ... deleted
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0781.html |