Bug 1102138 - test_gears_complete never prints "Waiting for gear upgrades to be completed." and can appear hung.
Summary: test_gears_complete never prints "Waiting for gear upgrades to be completed."...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 2.1.0
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
: ---
Assignee: Luke Meyer
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-28 14:30 UTC by Timothy Williams
Modified: 2018-12-05 18:42 UTC (History)
8 users (show)

Fixed In Version: openshift-enterprise-upgrade-2.1.7-1.el6op
Doc Type: Enhancement
Doc Text:
The ose-upgrade tool coordinates running a number of scripts to perform an OpenShift Enterprise version upgrade. When running the scripts, the tool previously displayed script output only after completion, even though several steps of the upgrade can take a long time, for example while updating RPMs or waiting on another host to complete its steps. This meant that administrators had no method for verifying what the tool was doing or whether something had gone wrong while the scripts were running. This enhancement updates the tool to display ongoing output from the scripts while they are running, and administrators are now able to better check the status of the scripts being run.
Clone Of:
Environment:
Last Closed: 2014-10-02 13:59:23 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:1353 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 2.1.7 bug fix and enhancement update 2014-10-02 17:59:00 UTC

Comment 1 nicholas_schuetz 2014-05-28 14:54:53 UTC 
You may also want to change the message to:

"Waiting for 'ose-upgrade gears' step on the broker to be completed."

Something to tell people that they're waiting on this step of the broker upgrade to complete before the node upgrade can be finished.
Comment 3 Luke Meyer 2014-06-05 17:53:31 UTC 
In general it would be a good idea to display the output from scripts as it is generated, not after the script completes. Look at oo-install enterprise launcher.rb for an example of doing this in ruby.

For steps that fail, we may want to re-display the step output with the failure color coding.
Comment 7 Johnny Liu 2014-09-22 05:47:57 UTC 
Need a puddle to verify this bug, so pls help build a puddle.
Comment 8 Johnny Liu 2014-09-22 08:43:49 UTC 
Test this bug with openshift-enterprise-release-2.2.0-1.git.39.c9de878.el6op.noarch against ose-2.2 upgrade, it is working well now.

On node, when broker is upgrading gears, the following message is printed out until gear upgrade is finished.
<--snip-->
INFO: running /usr/lib/ruby/site_ruby/1.8/ose-upgrade/node/upgrades/4/test_gears_complete/10-node-test-gear-migration-completed:
INFO: --BEGIN OUTPUT--
Waiting for gear upgrades to be completed.
Waiting for gear upgrades to be completed.
Waiting for gear upgrades to be completed.
Waiting for gear upgrades to be completed.
Waiting for gear upgrades to be completed.
<--snip-->


@Luke, do you plan change message mentioned in comment 1?

BTW, this bug will not be moved to "verified", just as what was said in comment7, QE will wait a ose-2.1.z puddle build to finish the whole verification.
Comment 9 Luke Meyer 2014-09-22 14:59:36 UTC 
(In reply to Johnny Liu from comment #8)

> @Luke, do you plan change message mentioned in comment 1?

Thanks, I missed that. Yes, I think it's a good idea to change that.
Comment 12 Johnny Liu 2014-09-23 09:47:03 UTC 
Verified this bug with openshift-enterprise-release-2.1.6-1.git.5.5eab834.el6op.noarch and openshift-enterprise-upgrade-node-2.1.6-1.git.5.5eab834.el6op.noarch, PASS.


On node, when broker is upgrading gears, the following message is printed out until gear upgrade is finished.
<--snip-->
INFO: Next step is 'test_gears_complete'
INFO: Setting node step 'test_gears_complete' status to UPGRADING
INFO: Running upgrade scripts in /usr/lib/ruby/site_ruby/1.8/ose-upgrade/node/upgrades/3/test_gears_complete
INFO: running /usr/lib/ruby/site_ruby/1.8/ose-upgrade/node/upgrades/3/test_gears_complete/10-node-test-gear-migration-completed:
INFO: --BEGIN OUTPUT--
Waiting for 'ose-upgrade gears' step on the broker to be completed.
Waiting for 'ose-upgrade gears' step on the broker to be completed.
Waiting for 'ose-upgrade gears' step on the broker to be completed.
Waiting for 'ose-upgrade gears' step on the broker to be completed.
<--snip-->
Comment 14 errata-xmlrpc 2014-10-02 13:59:23 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1353.html
Note You need to log in before you can comment on or make changes to this bug.