Description of problem: Currently the VIM APIs including session creation API are retried for cases which are unrelated to connection or session overload problems. This change fix the retry logic as follows: * Add an exception to indicate connection problem and raise it appropriately from the VIM API client * Modify the expected exceptions in the retry decorator to include only connection and session overload related exceptions This change also fixes the base class of VimFaultException (VolumeBackendAPIException -> VimException). This change is required so that we can handle the exceptions thrown by the VIM API client in a consistent manner. Currently if we need to handle VIM API related exceptions, we have to catch both VimException and VimFaultException. For example, the API for checking active session raises VimFaultException in some cases and we are handling only VimException. Due to this, when session expires, the session re-establishment and API retry fails (intermittently) since the check for active session throws VimFaultException in some cases which is not handled. Change-Id: I72cfc7777c3ce693b8598633f822c12c2cee2235 Closes-Bug: #1294598 Closes-Bug: #1302514 (cherry picked from commit bc115eaa477d30826ac17986a6e45844b456e206)
This has already been merged from upstream stable.
Tests just finished OK. No regression found.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-1325.html